Bug 45714 – chromium/mac: crash less in compositor mode

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

chromium/mac: crash less in compositor mode

[Nico Weber]

Created attachment 67481 [details]
Patch

[Nico Weber]

I didn't do the skia part since NativeImageSkia only has an SkBitmap copy constructor, not a NativeImageSkia copy constructor, and I wasn't sure how important that "is complete?" stuff is. Also, I don't have a machine/build with skia set up, so maybe one of you could deal with the non-mac part?

[James Robinson]

Comment on attachment 67481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67481&action=prettypatch

I think the compiler-generated copy constructor for NativeImageSkia should work OK, but that would have to be checked.  Could you just file another bug on the skia part?

ChangeLog format is odd here - normally this would be something like "[chromium] Image layers crash on mac because ..."

[Nico Weber]

Created attachment 67487 [details]
Patch

[Nico Weber]

Updated changelog, filed https://bugs.webkit.org/show_bug.cgi?id=45717 for skia.

[Darin Fisher (:fishd, Google)]

Comment on attachment 67487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67487&action=prettypatch

> WebCore/platform/graphics/chromium/ImageLayerChromium.h:61
> +    // FIXME: This needs to be an owning type.
In the Skia build, NativeImagePtr roughly corresponds to a SkBitmap, which is itself an owning (ref-counted internally) type.  Perhaps you can just make this be a NativeImageSkia then?

[Darin Fisher (:fishd, Google)]

Comment on attachment 67487 [details]
Patch

OK, I see that you guys already discussed NativeImageSkia.  R=me

[WebKit Commit Bot]

Comment on attachment 67487 [details]
Patch

Clearing flags on attachment: 67487

Committed r67477: <http://trac.webkit.org/changeset/67477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/67477 might have broken Chromium Win Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67476
http://trac.webkit.org/changeset/67477

[Nico Weber]

Yes, I broke this (I wrote #elif instead of #else). But tony^work fixed it already.