Bug 45569 - Move code from WebKit-layer to DocumentLoader
Summary: Move code from WebKit-layer to DocumentLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 29947
  Show dependency tree / graph
 
Reported: 2010-09-10 15:52 PDT by Adam Barth
Modified: 2010-09-10 19:15 PDT (History)
4 users (show)

See Also:

Attachments
work in progress (38.53 KB, patch)
2010-09-10 15:58 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (39.09 KB, patch)
2010-09-10 16:34 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-10 15:52:39 PDT 
Move code from WebKit-layer to DocumentLoader
Comment 1 Adam Barth 2010-09-10 15:58:57 PDT 
Created attachment 67252 [details]
work in progress
Comment 2 Darin Fisher (:fishd, Google) 2010-09-10 16:13:50 PDT 
Comment on attachment 67252 [details]
work in progress

View in context: https://bugs.webkit.org/attachment.cgi?id=67252&action=prettypatch

> WebKit/chromium/src/WebFrameImpl.cpp:1017
> +    m_frame->loader()->documentLoader()->commitDocumentData(data, length);
I think you meant commitData here.
Comment 3 Adam Barth 2010-09-10 16:21:39 PDT 
(In reply to comment #2)
> (From update of attachment 67252 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67252&action=prettypatch
> 
> > WebKit/chromium/src/WebFrameImpl.cpp:1017
> > +    m_frame->loader()->documentLoader()->commitDocumentData(data, length);
> I think you meant commitData here.

Yep.  Thanks.  That was the original name, but the "document" part seemed redundant.  :)
Comment 4 Adam Barth 2010-09-10 16:34:14 PDT 
Created attachment 67261 [details]
Patch
Comment 5 Darin Fisher (:fishd, Google) 2010-09-10 16:43:58 PDT 
Comment on attachment 67261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67261&action=prettypatch

> WebCore/WebCore.xcodeproj/project.pbxproj:-20630
> -			developmentRegion = English;
not sure about this change.  seems unrelated.

otherwise, r=me
Comment 6 Adam Barth 2010-09-10 17:02:05 PDT 
(In reply to comment #5)
> (From update of attachment 67261 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67261&action=prettypatch
> 
> > WebCore/WebCore.xcodeproj/project.pbxproj:-20630
> > -			developmentRegion = English;
> not sure about this change.  seems unrelated.

This is a commit war between different versions of Xcode.  The consensus last time we discussed it as a community was to just have the commit war and eventually the bug in Xcode will be fixed.
Comment 7 Adam Barth 2010-09-10 17:50:03 PDT 
Comment on attachment 67261 [details]
Patch

Clearing flags on attachment: 67261

Committed r67253: <http://trac.webkit.org/changeset/67253>
Comment 8 Adam Barth 2010-09-10 17:50:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2010-09-10 19:15:20 PDT 
http://trac.webkit.org/changeset/67253 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67253
http://trac.webkit.org/changeset/67254
http://trac.webkit.org/changeset/67255