Bug 45569 – Move code from WebKit-layer to DocumentLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Move code from WebKit-layer to DocumentLoader

[Adam Barth]

Created attachment 67252 [details]
work in progress

[Darin Fisher (:fishd, Google)]

Comment on attachment 67252 [details]
work in progress

View in context: https://bugs.webkit.org/attachment.cgi?id=67252&action=prettypatch

> WebKit/chromium/src/WebFrameImpl.cpp:1017
> +    m_frame->loader()->documentLoader()->commitDocumentData(data, length);
I think you meant commitData here.

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 67252 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67252&action=prettypatch
> 
> > WebKit/chromium/src/WebFrameImpl.cpp:1017
> > +    m_frame->loader()->documentLoader()->commitDocumentData(data, length);
> I think you meant commitData here.

Yep.  Thanks.  That was the original name, but the "document" part seemed redundant.  :)

[Adam Barth]

Created attachment 67261 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 67261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67261&action=prettypatch

> WebCore/WebCore.xcodeproj/project.pbxproj:-20630
> -			developmentRegion = English;
not sure about this change.  seems unrelated.

otherwise, r=me

[Adam Barth]

(In reply to comment #5)
> (From update of attachment 67261 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67261&action=prettypatch
> 
> > WebCore/WebCore.xcodeproj/project.pbxproj:-20630
> > -			developmentRegion = English;
> not sure about this change.  seems unrelated.

This is a commit war between different versions of Xcode.  The consensus last time we discussed it as a community was to just have the commit war and eventually the bug in Xcode will be fixed.

[Adam Barth]

Comment on attachment 67261 [details]
Patch

Clearing flags on attachment: 67261

Committed r67253: <http://trac.webkit.org/changeset/67253>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/67253 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67253
http://trac.webkit.org/changeset/67254
http://trac.webkit.org/changeset/67255