Bug 45481 - Inline FrameLoader::committedLoad into its one caller
Summary: Inline FrameLoader::committedLoad into its one caller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 29947
  Show dependency tree / graph
 
Reported: 2010-09-09 11:37 PDT by Adam Barth
Modified: 2010-09-10 07:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2010-09-09 11:39 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (3.18 KB, patch)
2010-09-09 12:18 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-09 11:37:04 PDT 
Inline FrameLoader::committedLoad into its one caller
Comment 1 Adam Barth 2010-09-09 11:39:04 PDT 
Created attachment 67072 [details]
Patch
Comment 2 Early Warning System Bot 2010-09-09 11:50:28 PDT 
Attachment 67072 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3943343
Comment 3 Eric Seidel (no email) 2010-09-09 12:01:13 PDT 
Attachment 67072 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3921337
Comment 4 Eric Seidel (no email) 2010-09-09 12:11:08 PDT 
Comment on attachment 67072 [details]
Patch

It appears you're missing an include?
../../../WebCore/loader/DocumentLoader.cpp: In member function 'void WebCore::DocumentLoader::commitLoad(const char*, int)':
../../../WebCore/loader/DocumentLoader.cpp:285: error: invalid use of incomplete type 'struct WebCore::FrameLoaderClient'
../../../WebCore/loader/SubframeLoader.h:45: error: forward declaration of 'struct WebCore::FrameLoaderClient'

Otherwise seems fine.
Comment 5 Adam Barth 2010-09-09 12:18:41 PDT 
Created attachment 67077 [details]
Patch for landing
Comment 6 Eric Seidel (no email) 2010-09-09 14:42:17 PDT 
ews hung on this patch:

Failed to run "['WebKitTools/Scripts/build-webkit', '--release']" exit_code: 1
Adding comment to bug 45481
Comment 7 WebKit Commit Bot 2010-09-10 07:30:53 PDT 
Comment on attachment 67077 [details]
Patch for landing

Clearing flags on attachment: 67077

Committed r67198: <http://trac.webkit.org/changeset/67198>
Comment 8 WebKit Commit Bot 2010-09-10 07:30:58 PDT 
All reviewed patches have been landed.  Closing bug.