Bug 45466 – [WINCE] Replace codePage instead of TextEncoding

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 67052 [details]
Patch

[WebKit Review Bot]

Attachment 67052 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/text/wince/TextCodecWinCE.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 67052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67052&action=prettypatch

> WebCore/ChangeLog:8
> +        Use codePage as member variable to aviod repeated lookup.
Typo: aviod

> WebCore/platform/text/wince/TextCodecWinCE.cpp:136
> -    return new TextCodecWinCE(encoding);
> +    return new TextCodecWinCE(getCodePage(encoding.name()));
Another option would have been to put the call to getCodePage inside the TextCodecWinCE constructor. It isn't clear to me whether that approach would be better.

[Patrick R. Gansterer]

Created attachment 67558 [details]
Patch

(In reply to comment #3)
> > WebCore/platform/text/wince/TextCodecWinCE.cpp:136
> > -    return new TextCodecWinCE(encoding);
> > +    return new TextCodecWinCE(getCodePage(encoding.name()));
> Another option would have been to put the call to getCodePage inside the TextCodecWinCE constructor. It isn't clear to me whether that approach would be better.
IMHO there is no difference.

[Adam Roben (:aroben)]

Comment on attachment 67558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67558&action=prettypatch

r=me

[WebKit Commit Bot]

Comment on attachment 67558 [details]
Patch

Clearing flags on attachment: 67558

Committed r67523: <http://trac.webkit.org/changeset/67523>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.