WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45411
LayoutTest regressions due to
http://trac.webkit.org/changeset/67001
https://bugs.webkit.org/show_bug.cgi?id=45411
Summary
LayoutTest regressions due to http://trac.webkit.org/changeset/67001
Peter Kasting
Reported
2010-09-08 13:25:18 PDT
http://trac.webkit.org/changeset/67001
caused the following four tests to fail: fast/events/continuous-platform-wheelevent-in-scrolling-div.html fast/events/scroll-event-does-not-bubble.html fast/events/spatial-navigation/snav-only-clipped-overflow-content.html fast/events/wheelevent-in-scrolling-div.html There seem to be a couple different issues. One is that horizontal scrolling is scrolling the wrong distance. I assumed at first that this was from my setValue() -> scroll() conversions in
http://trac.webkit.org/changeset/67001/trunk/WebCore/platform/qt/ScrollbarQt.cpp
, but not only do they not seem wrong, I now think they can't be at fault because they only handle context menu actions (right?). The other problem has to do with event bubbling.
Attachments
Add attachment
proposed patch, testcase, etc.
Peter Kasting
Comment 1
2010-09-08 13:34:02 PDT
http://trac.webkit.org/changeset/67009
added these to the Qt Skipped list to keep the bot green.
Antonio Gomes
Comment 2
2010-09-08 14:28:27 PDT
(In reply to
comment #0
)
>
http://trac.webkit.org/changeset/67001
caused the following four tests to fail: > fast/events/spatial-navigation/snav-only-clipped-overflow-content.html
it is likely due to
bug 43030
. I am going to look at it soon, when I get some time. Thank you skipping pkasting.
Csaba Osztrogonác
Comment 3
2010-09-08 15:32:07 PDT
Skip more 4 tests, they fail intermittently: fast/events/platform-wheelevent-in-scrolling-div.html fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html platform/qt/fast/events/event-sender-keydown-frame.html fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html
http://trac.webkit.org/changeset/67026
Csaba Osztrogonác
Comment 4
2010-09-08 15:33:47 PDT
(In reply to
comment #3
)
> Skip more 4 tests, they fail intermittently: > fast/events/platform-wheelevent-in-scrolling-div.html > fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html > platform/qt/fast/events/event-sender-keydown-frame.html > fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html > >
http://trac.webkit.org/changeset/67026
It might be a DRT sideeffect bug, a real bug revealed by this change, using uninitialized variable, etc. I'll check it tomorrow.
Peter Kasting
Comment 5
2010-09-08 20:16:58 PDT
I know the cause of at least the "scrolling the wrong distance" issues. I failed to properly initialize some members. Patched in
http://trac.webkit.org/changeset/67052
. I didn't remove any tests from the Qt Skipped lists yet, but this may address the majority of the problems here.
Csaba Osztrogonác
Comment 6
2010-09-08 22:36:18 PDT
I tested the skipped tests again, and it seems your fix works, so I unskipped tests:
http://trac.webkit.org/changeset/67061
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug