Bug 45137 – http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Zhenyao Mo]

Disabled it for now: http://trac.webkit.org/changeset/66687

[Andrey Kosyakov]

Created attachment 66499 [details]
patch

[Andrey Kosyakov]

Manually committed r66735: http://trac.webkit.org/changeset/66735

[WebKit Review Bot]

http://trac.webkit.org/changeset/66735 might have broken Qt Linux Release

[Alexey Proskuryakov]

+        Changed MIME type for .js to application/x-javascript in lighttpd.conf for
+        consistency with apache used on other platforms.

This patch seems to be doing a lot more than that.

[Eric Seidel (no email)]

Comment on attachment 66499 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66499&action=prettypatch

> LayoutTests/ChangeLog:6
> +        Use CGI as target for POST request to prevent HTTP 405 on certain platforms.
Which platforms?  Please list in your ChangeLog.

[Andrey Kosyakov]

(In reply to comment #4)
> +        Changed MIME type for .js to application/x-javascript in lighttpd.conf for
> +        consistency with apache used on other platforms.
> 
> This patch seems to be doing a lot more than that.

Alexey, you're quoting WebKitTools/ChangeLog. The rest of the change applies to LayoutTests and is summarized in LayoutTests/ChangeLog as "Use CGI as target for POST request to prevent HTTP 405 on certain platforms."

[Alexey Proskuryakov]

I was actually quoting the latter, and I overlooked this part. Maybe just sloppiness on my part, but this also highlights why we ask for per-file or per-funciton comments in ChangeLogs.

[Andrey Kosyakov]

Updated LayoutTests/ChangeLog to include more details, committed as r66749: http://trac.webkit.org/changeset/66749

[Eric Seidel (no email)]

Thank you.