Bug 45109 – Web Inspector: HAR converter fails on POST requests with non-form content type

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

HAREntry.convert() fails in HAREntry._buildParameters() when passed a resource that has POST data with content-type other application/x-www-form-urlencoded.
The problem currently appears only in extensions that request resource data when inspecting sites that do XHRs.

[Andrey Kosyakov]

Created attachment 66368 [details]
Patch

[WebKit Review Bot]

http://trac.webkit.org/changeset/66669 might have broken SnowLeopard Intel Release (Tests)

[Joseph Pecoraro]

Andrey, when you land a patch please update the Bugzilla bug
with a link to trac and move its state from "unconfirmed" to
"resolved > fixed". Is that the case here?

[Andrey Kosyakov]

(In reply to comment #3)
> Andrey, when you land a patch please update the Bugzilla bug
> with a link to trac and move its state from "unconfirmed" to
> "resolved > fixed". Is that the case here?

Thanks, I normally do this, I was just waiting for a follow-up patch with the test fix to land.

[Andrey Kosyakov]

Manually committed r66669: http://trac.webkit.org/changeset/66669
Test fix committed as r66672: http://trac.webkit.org/changeset/66672

[Joseph Pecoraro]

> Thanks, I normally do this, I was just waiting for a follow-up patch
> with the test fix to land.

I see. In any case, posting the trac link as soon as a patch lands is
more useful than marking the bug resolved. I often do the same thing,
I land, post some info on the bug and let them know I'm "watching
the bots", and mark it resolved a little later when the bots have passed.