Bug 45109 - Web Inspector: HAR converter fails on POST requests with non-form content type
Summary: Web Inspector: HAR converter fails on POST requests with non-form content type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45137
  Show dependency treegraph
 
Reported: 2010-09-02 07:04 PDT by Andrey Kosyakov
Modified: 2010-09-14 08:34 PDT (History)
12 users (show)

See Also:


Attachments
Patch (10.91 KB, patch)
2010-09-02 07:22 PDT, Andrey Kosyakov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2010-09-02 07:04:40 PDT
HAREntry.convert() fails in HAREntry._buildParameters() when passed a resource that has POST data with content-type other application/x-www-form-urlencoded.
The problem currently appears only in extensions that request resource data when inspecting sites that do XHRs.
Comment 1 Andrey Kosyakov 2010-09-02 07:22:41 PDT
Created attachment 66368 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-02 09:08:49 PDT
http://trac.webkit.org/changeset/66669 might have broken SnowLeopard Intel Release (Tests)
Comment 3 Joseph Pecoraro 2010-09-02 09:55:23 PDT
Andrey, when you land a patch please update the Bugzilla bug
with a link to trac and move its state from "unconfirmed" to
"resolved > fixed". Is that the case here?
Comment 4 Andrey Kosyakov 2010-09-02 11:02:04 PDT
(In reply to comment #3)
> Andrey, when you land a patch please update the Bugzilla bug
> with a link to trac and move its state from "unconfirmed" to
> "resolved > fixed". Is that the case here?

Thanks, I normally do this, I was just waiting for a follow-up patch with the test fix to land.
Comment 5 Andrey Kosyakov 2010-09-02 11:04:38 PDT
Manually committed r66669: http://trac.webkit.org/changeset/66669
Test fix committed as r66672: http://trac.webkit.org/changeset/66672
Comment 6 Joseph Pecoraro 2010-09-02 11:06:07 PDT
> Thanks, I normally do this, I was just waiting for a follow-up patch
> with the test fix to land.

I see. In any case, posting the trac link as soon as a patch lands is
more useful than marking the bug resolved. I often do the same thing,
I land, post some info on the bug and let them know I'm "watching
the bots", and mark it resolved a little later when the bots have passed.