Bug 45089 - [EFL] Remove GOwnPtr to OwnPtr in FontCacheCairo.cpp
Summary: [EFL] Remove GOwnPtr to OwnPtr in FontCacheCairo.cpp
Status: RESOLVED DUPLICATE of bug 45053
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 22:46 PDT by Ryuan Choi
Modified: 2010-09-15 11:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.49 KB, patch)
2010-09-01 22:58 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2010-09-01 22:46:09 PDT 
Because FontCacheCairo use GOwnPtr,
EWebKit can't remove glib dependency without GLIB_SUPPORT.

I suggest to change GOwnPtr to OwnPtr at below code in FontCacheCairo.

    GOwnPtr<FcPattern> pattern(FcPatternCreate());
    if (!FcPatternAddString(pattern.get(), FC_FAMILY, reinterpret_cast<const FcChar8*>(fcfamily)))
        return 0;

    GOwnPtr<FcObjectSet> objectSet(FcObjectSetCreate());
    if (!FcObjectSetAdd(objectSet.get(), FC_FAMILY))
        return 0;

    GOwnPtr<FcFontSet> fontSet(FcFontList(0, pattern.get(), objectSet.get()));
Comment 1 Ryuan Choi 2010-09-01 22:58:26 PDT 
Created attachment 66335 [details]
Patch
Comment 2 Rafael Antognolli 2010-09-02 09:18:56 PDT 
Hi Ryuan,

I think you sent exactly the same patch that I sent in bug 45053 :P
Comment 3 Ryuan Choi 2010-09-05 04:10:23 PDT 
yes, Sorry I didn't see :)

*** This bug has been marked as a duplicate of bug 45053 ***
Comment 4 Martin Robinson 2010-09-15 11:58:52 PDT 
Comment on attachment 66335 [details]
Patch

Clearing flags, as this has already landed elsewhere.