Bug 45053 - [Cairo] Remove glib dependency (caused by use of GOwnPtr)
Summary: [Cairo] Remove glib dependency (caused by use of GOwnPtr)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 45089 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-01 13:08 PDT by Rafael Antognolli
Modified: 2010-09-05 04:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2010-09-01 13:09 PDT, Rafael Antognolli 		no flags Details | Formatted Diff | Diff
Patch (6.31 KB, patch)
2010-09-01 13:48 PDT, Rafael Antognolli 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Antognolli 2010-09-01 13:08:18 PDT 
The use of GOwnPtr was introduced on platform/graphics/cairo/FontCacheCairo.cpp in order to keep references for Fc* functions. But this implies on a dependency on glib headers, since the forwarded declarations are now specific to Gtk.

Maybe the GOwnPtrCairo could be based on OwnPtr instead of GOwnPtr. What do you think about this?

I'm attaching a patch that implements this, but I didn't add the name change and fixed all the builds yet. Please tell me what you think about this, then I'll finish it.
Comment 1 Rafael Antognolli 2010-09-01 13:09:08 PDT 
Created attachment 66251 [details]
Patch
Comment 2 Martin Robinson 2010-09-01 13:10:59 PDT 
I approve of this change.
Comment 3 Rafael Antognolli 2010-09-01 13:48:53 PDT 
Created attachment 66260 [details]
Patch
Comment 4 Martin Robinson 2010-09-02 10:45:47 PDT 
A related comment about RefPtr: https://bugs.webkit.org/show_bug.cgi?id=44354#c17

In my opinion, we should use OwnPtr specializations for everything that isn't a void*. For things that are void*, we should find some other solution.
Comment 5 Martin Robinson 2010-09-02 10:46:58 PDT 
Comment on attachment 66260 [details]
Patch

I think this is the right direction to go in.
Comment 6 WebKit Commit Bot 2010-09-02 18:39:16 PDT 
Comment on attachment 66260 [details]
Patch

Clearing flags on attachment: 66260

Committed r66700: <http://trac.webkit.org/changeset/66700>
Comment 7 WebKit Commit Bot 2010-09-02 18:39:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Ryuan Choi 2010-09-05 04:10:23 PDT 
*** Bug 45089 has been marked as a duplicate of this bug. ***