Bug 44911 - check-webkit-style should understand WTF #include guards
Summary: check-webkit-style should understand WTF #include guards
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
Depends on: 44892
  Show dependency treegraph
Reported: 2010-08-30 17:21 PDT by Kenneth Russell
Modified: 2010-12-17 05:15 PST (History)
6 users (show)

See Also:

Patch (4.80 KB, patch)
2010-12-16 16:59 PST, David Levin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-08-30 17:21:14 PDT
Many of the files in JavaScriptCore/wtf use a different #include guard than those used in WebCore; e.g., "#ifndef WTF_Vector_h" rather than "#ifndef Vector_h". This does seem to be a good idea to avoid clashes between potentially similarly-named headers in WTF and WebCore, since the #include style is different ('#include <wtf/Vector.h>' rather than '#include "Vector.h"'). check-webkit-style complains about the addition of new WTF_ prefixed #include guards; I think it should be taught about them. See https://bugs.webkit.org/show_bug.cgi?id=44892 for one instance where it complained.
Comment 1 David Levin 2010-12-16 16:59:06 PST
Created attachment 76830 [details]
Comment 2 Eric Seidel (no email) 2010-12-17 03:56:43 PST
Comment on attachment 76830 [details]

LGTM.  Thanks.
Comment 3 WebKit Commit Bot 2010-12-17 05:15:50 PST
Comment on attachment 76830 [details]

Clearing flags on attachment: 76830

Committed r74255: <http://trac.webkit.org/changeset/74255>
Comment 4 WebKit Commit Bot 2010-12-17 05:15:56 PST
All reviewed patches have been landed.  Closing bug.