Bug 44892 – Fix namespace for wtf/Complex.h and wtf/Vector3.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chris Rogers]

Fix namespace for wtf/Complex.h and wtf/Vector3.h

[Chris Rogers]

Created attachment 65954 [details]
Patch

[Kenneth Russell]

Comment on attachment 65954 [details]
Patch

The #if guards are incorrect for these files as well.

[Chris Rogers]

Created attachment 65978 [details]
Patch

[WebKit Review Bot]

Attachment 65978 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/Vector3.h:29:  #ifndef header guard has wrong style, please use: Vector3_h  [build/header_guard] [5]
JavaScriptCore/wtf/Complex.h:29:  #ifndef header guard has wrong style, please use: Complex_h  [build/header_guard] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Russell]

Comment on attachment 65978 [details]
Patch

I think the updates to the #include guards are the right thing to do regardless of what check-webkit-style says. r=me. Will file a bug against check-webkit-style.

[Chris Rogers]

Comment on attachment 65978 [details]
Patch

Clearing flags on attachment: 65978

Committed r66446: <http://trac.webkit.org/changeset/66446>

[Chris Rogers]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Please note that WTF symbols expected to be used in other projects need to have using declarations. We don't want to pollute WebCore with those (or with WTF:: prefixes), so we put them right into WTF headers.

See e.g. Vector.h:


} // namespace WTF

using WTF::Vector;

#endif // WTF_Vector_h