Bug 44892 - Fix namespace for wtf/Complex.h and wtf/Vector3.h
Summary: Fix namespace for wtf/Complex.h and wtf/Vector3.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 44911
  Show dependency treegraph
 
Reported: 2010-08-30 14:21 PDT by Chris Rogers
Modified: 2010-08-31 10:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2010-08-30 14:23 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2010-08-30 16:48 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-08-30 14:21:12 PDT
Fix namespace for wtf/Complex.h and wtf/Vector3.h
Comment 1 Chris Rogers 2010-08-30 14:23:20 PDT
Created attachment 65954 [details]
Patch
Comment 2 Kenneth Russell 2010-08-30 16:20:19 PDT
Comment on attachment 65954 [details]
Patch

The #if guards are incorrect for these files as well.
Comment 3 Chris Rogers 2010-08-30 16:48:58 PDT
Created attachment 65978 [details]
Patch
Comment 4 WebKit Review Bot 2010-08-30 16:52:25 PDT
Attachment 65978 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/Vector3.h:29:  #ifndef header guard has wrong style, please use: Vector3_h  [build/header_guard] [5]
JavaScriptCore/wtf/Complex.h:29:  #ifndef header guard has wrong style, please use: Complex_h  [build/header_guard] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Kenneth Russell 2010-08-30 17:15:45 PDT
Comment on attachment 65978 [details]
Patch

I think the updates to the #include guards are the right thing to do regardless of what check-webkit-style says. r=me. Will file a bug against check-webkit-style.
Comment 6 Chris Rogers 2010-08-30 19:05:02 PDT
Comment on attachment 65978 [details]
Patch

Clearing flags on attachment: 65978

Committed r66446: <http://trac.webkit.org/changeset/66446>
Comment 7 Chris Rogers 2010-08-30 19:05:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2010-08-31 10:15:40 PDT
Please note that WTF symbols expected to be used in other projects need to have using declarations. We don't want to pollute WebCore with those (or with WTF:: prefixes), so we put them right into WTF headers.

See e.g. Vector.h:


} // namespace WTF

using WTF::Vector;

#endif // WTF_Vector_h