Bug 44840 - [chromium] Create webcore_svg with all the svg sources.
Summary: [chromium] Create webcore_svg with all the svg sources.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 44814
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-29 08:24 PDT by Marc-Antoine Ruel
Modified: 2010-08-30 00:47 PDT (History)
1 user (show)

See Also:

Attachments
webcore.gyp patch (3.94 KB, patch)
2010-08-29 13:17 PDT, Marc-Antoine Ruel 		tkent: review+
tkent: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Antoine Ruel 2010-08-29 08:24:03 PDT 
Remove svg sources from webcore_remaining and move them to webcore_svg.
Comment 1 Marc-Antoine Ruel 2010-08-29 13:17:51 PDT 
Created attachment 65861 [details]
webcore.gyp patch

Is http://codereview.chromium.org/3215007/show patchset 5. Compiles on all platforms in both incremental and clobber build. Requires the dependent bugs to be checked in first.
Comment 2 Kent Tamura 2010-08-30 00:31:20 PDT 
Comment on attachment 65861 [details]
webcore.gyp patch

Looks ok.
Comment 3 Kent Tamura 2010-08-30 00:32:18 PDT 
Comment on attachment 65861 [details]
webcore.gyp patch

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 816360a..a67a88d 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,12 @@
> +2010-08-29  Marc-Antoine Ruel  <maruel@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Split webcore_svg off webcore_remaining. webcore_svg contains all svg
> +        sources files.
> +
> +        * WebCore.gyp/WebCore.gyp:
> +

Should add the bug URL to the ChangeLog entry.
Comment 4 Kent Tamura 2010-08-30 00:47:35 PDT 
Landed: http://trac.webkit.org/changeset/66373