Bug 44814 – [chromium] Move all the remaining dependencies in webcore_remaining into webcore_prerequisites

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Marc-Antoine Ruel]

Move all the remaining dependencies in webcore_remaining into webcore_prerequisites

[Marc-Antoine Ruel]

Created attachment 65809 [details]
webcore.gyp patch

[Marc-Antoine Ruel]

Original code review http://codereview.chromium.org/3225004

[Marc-Antoine Ruel]

Created attachment 65811 [details]
webcore.gyp patch

Rebase against HEAD

[Dimitri Glazkov (Google)]

Comment on attachment 65811 [details]
webcore.gyp patch

ok.

[WebKit Commit Bot]

Comment on attachment 65811 [details]
webcore.gyp patch

Rejecting patch 65811 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/WebCore.gyp/WebCore.gyp
Hunk #1 FAILED at 873.
Hunk #2 FAILED at 887.
Hunk #3 FAILED at 920.
Hunk #4 FAILED at 956.
Hunk #5 FAILED at 1111.
Hunk #6 succeeded at 1083 (offset -42 lines).
Hunk #7 FAILED at 1099.
Hunk #8 succeeded at 1267 with fuzz 1 (offset 6 lines).
6 out of 8 hunks FAILED -- saving rejects to file WebCore/WebCore.gyp/WebCore.gyp.rej

Full output: http://queues.webkit.org/results/3885073

[Marc-Antoine Ruel]

Created attachment 65853 [details]
webcore.gyp patch

http://codereview.chromium.org/3225004 patchset 3.

[Kent Tamura]

Comment on attachment 65853 [details]
webcore.gyp patch

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 2da30fe..816360a 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -2,6 +2,14 @@
>  
>          Reviewed by NOBODY (OOPS!).
>  
> +        Move most dependencies to webcore_prerequisites
> +
> +        * WebCore.gyp/WebCore.gyp:
> +
> [phone]  Marc-Antoine Ruel  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
>          Move more common settings to webcore_prerequisites
>  
>          * WebCore.gyp/WebCore.gyp:

Please add the bug URL to the ChangeLog entry.

[Kent Tamura]

Landed: http://trac.webkit.org/changeset/66370

[WebKit Review Bot]

http://trac.webkit.org/changeset/66370 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66369
http://trac.webkit.org/changeset/66370