Bug 44702 - Make it possible for http tests to log resource requests
Summary: Make it possible for http tests to log resource requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 11:56 PDT by Simon Fraser (smfr)
Modified: 2010-08-26 13:16 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.88 KB, patch)
2010-08-26 12:33 PDT, Simon Fraser (smfr)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-08-26 11:56:45 PDT
For bug 24223, I need to be able to log individual resource requests.
Comment 1 Simon Fraser (smfr) 2010-08-26 12:33:44 PDT
Created attachment 65599 [details]
Patch
Comment 2 Alexey Proskuryakov 2010-08-26 13:02:51 PDT
Comment on attachment 65599 [details]
Patch

> +main frame - didStartProvisionalLoadForFrame
> +main frame - didCommitLoadForFrame
> +main frame - didFinishDocumentLoadForFrame
> +main frame - didHandleOnloadEventsForFrame
> +main frame - didFinishLoadForFrame

It seems like this test needn't be in loading subdirectory - or we need a way to avoid this noise output.

+    generateNoCacheHTTPHeader();
+    header("Last-Modified: " . gmdate("D, d M Y H:i:s T", filemtime($resourceLogFile)));

Why bother with Last-Modified if the response not cacheable?

r=me.
Comment 3 Simon Fraser (smfr) 2010-08-26 13:16:03 PDT
http://trac.webkit.org/changeset/66128