Bug 24223 – CSS downloads all background images related to element, instead of just final rule

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Lee Powell]

When an element is given a background image, that is later over ruled with another background image later on in the css cascade, webkit downloads both images.

Check the link for an example, and then view the Resources in the Inspector panel.

[Dave Hyatt]

*** Bug 31630 has been marked as a duplicate of this bug. ***

[Andy Hume]

This seems to have been fixed in or before r65052?

[Simon Fraser (smfr)]

No, this still happens if the two images are referred to by different rule blocks.

[Simon Fraser (smfr)]

<rdar://problem/8354391>

[Simon Fraser (smfr)]

Created attachment 65526 [details]
Mostly complete patch

This patch works pretty well, but breaks one test: fast/css-generated-content/after-order.html

[Simon Fraser (smfr)]

Created attachment 65622 [details]
Patch

[WebKit Review Bot]

Attachment 65622 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/css/CSSStyleSelector.cpp:6725:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Comment on attachment 65622 [details]
Patch

r=me

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/66141

[Ryosuke Niwa]

http://trac.webkit.org/changeset/66141 seems to have caused fast/forms/select-style.html to fail on mac:

@@ -56,10 +56,10 @@
       RenderText {#text} at (0,160) size 498x18
         text run at (0,160) width 498: "This tests that background is white if only background-image:none is specified."
       RenderBR {BR} at (498,174) size 0x0
-      RenderMenuList {SELECT} at (2,180) size 51x18 [bgcolor=#FFFFFF]
-        RenderBlock (anonymous) at (0,0) size 51x18
-          RenderText at (8,2) size 20x13
-            text run at (8,2) width 20: "test"
+      RenderMenuList {SELECT} at (2,180) size 51x18 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
+        RenderBlock (anonymous) at (1,1) size 49x16
+          RenderText at (8,1) size 20x13
+            text run at (8,1) width 20: "test"
       RenderText {#text} at (55,179) size 4x18
         text run at (55,179) width 4: " "
       RenderBR {BR} at (59,193) size 0x0

[Simon Fraser (smfr)]

I filed bug 44737 to investigate the test breakage.

[Alexey Proskuryakov]

*** Bug 52847 has been marked as a duplicate of this bug. ***