Bug 44696 – Misc. cleanup from bug 32356

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Peter Kasting]

While working on bug 32356, I've touched a lot of code.  This bug is to hold a cleanup patch that splits out the non-functional changes I've made (e.g. style guide compliance, better line wrapping, etc.)

[Peter Kasting]

Created attachment 65583 [details]
patch v1

[WebKit Review Bot]

Attachment 65583 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/Scrollbar.cpp:150:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/platform/Scrollbar.cpp:149:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Peter Kasting]

Created attachment 65585 [details]
patch v1.1

Fix style errors.

[Dimitri Glazkov (Google)]

Comment on attachment 65585 [details]
patch v1.1

ok.

[Eric Seidel (no email)]

Attachment 65583 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3789566

[Peter Kasting]

Created attachment 65591 [details]
patch v1.2

Fix Mac build error due to (wrong) compiler warning.  Carrying over dglazkov's r+ and cq+.

[Dimitri Glazkov (Google)]

Comment on attachment 65591 [details]
patch v1.2

cycling the rrrr.

[WebKit Commit Bot]

Comment on attachment 65591 [details]
patch v1.2

Rejecting patch 65591 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--force']" exit_code: 1
Last 500 characters of output:
rImpl.cpp
Hunk #1 FAILED at 81.
Hunk #2 FAILED at 214.
2 out of 2 hunks FAILED -- saving rejects to file WebKit/chromium/src/WebScrollbarImpl.cpp.rej
patching file WebKit/chromium/src/WebViewImpl.cpp
Hunk #1 FAILED at 823.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebViewImpl.cpp.rej
patching file WebKit/chromium/src/win/WebInputEventFactory.cpp
Hunk #1 FAILED at 398.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/win/WebInputEventFactory.cpp.rej

Full output: http://queues.webkit.org/results/3851023

[Peter Kasting]

Shoot, I forgot to mark this fixed.  I landed this in r66126.