Bug 44633 – new-run-webkit-tests should respect set-webkit-configuration

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ojan Vafai]

I have set-webkit-configuration as --debug.

I did:
update-webkit --chromium
build-webkit --chromium
$new-run-webkit-tests --chromium --use-drt perf/
Defaulting to one child - see https://bugs.webkit.org/show_bug.cgi?id=38553
You are not running the most recent DumpRenderTree binary. You need to pass --debug or not to select between Debug and Release.

Build, built debug. new-run-webkit-tests should have as well.

[Adam Barth]

I thought we fixed this already.

[Ojan Vafai]

Created attachment 65470 [details]
Patch

[Dirk Pranke]

(In reply to comment #2)
> Created an attachment (id=65470) [details]
> Patch

Adam: we fixed this for webkit-based ports, but the chromium port never looked at the switches. It's not clear to me that it should, but I don't feel strongly about it one way or another. 

Having all the tools act consistently is a good thing, though, so if build-webkit and update-webkit both work for --chromium, then new-run-webkit-tests should as well.

Patch looks good to me. It would be good to actually port webkitdirs.pm over to python to consolidate code at some point ...

[Adam Barth]

Comment on attachment 65470 [details]
Patch

nice

[Ojan Vafai]

Committed r66041: <http://trac.webkit.org/changeset/66041>

[WebKit Review Bot]

http://trac.webkit.org/changeset/66041 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66041
http://trac.webkit.org/changeset/66042

[Dimitri Glazkov (Google)]

This doesn't work on Windows though. Fix coming up.