Bug 44633 - new-run-webkit-tests should respect set-webkit-configuration
Summary: new-run-webkit-tests should respect set-webkit-configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45180
  Show dependency treegraph
 
Reported: 2010-08-25 13:42 PDT by Ojan Vafai
Modified: 2010-09-03 10:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.03 KB, patch)
2010-08-25 14:03 PDT, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-08-25 13:42:26 PDT
I have set-webkit-configuration as --debug.

I did:
update-webkit --chromium
build-webkit --chromium
$new-run-webkit-tests --chromium --use-drt perf/
Defaulting to one child - see https://bugs.webkit.org/show_bug.cgi?id=38553
You are not running the most recent DumpRenderTree binary. You need to pass --debug or not to select between Debug and Release.

Build, built debug. new-run-webkit-tests should have as well.
Comment 1 Adam Barth 2010-08-25 13:51:00 PDT
I thought we fixed this already.
Comment 2 Ojan Vafai 2010-08-25 14:03:16 PDT
Created attachment 65470 [details]
Patch
Comment 3 Dirk Pranke 2010-08-25 14:08:47 PDT
(In reply to comment #2)
> Created an attachment (id=65470) [details]
> Patch

Adam: we fixed this for webkit-based ports, but the chromium port never looked at the switches. It's not clear to me that it should, but I don't feel strongly about it one way or another. 

Having all the tools act consistently is a good thing, though, so if build-webkit and update-webkit both work for --chromium, then new-run-webkit-tests should as well.

Patch looks good to me. It would be good to actually port webkitdirs.pm over to python to consolidate code at some point ...
Comment 4 Adam Barth 2010-08-25 14:12:50 PDT
Comment on attachment 65470 [details]
Patch

nice
Comment 5 Ojan Vafai 2010-08-25 14:16:59 PDT
Committed r66041: <http://trac.webkit.org/changeset/66041>
Comment 6 WebKit Review Bot 2010-08-25 15:24:46 PDT
http://trac.webkit.org/changeset/66041 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66041
http://trac.webkit.org/changeset/66042
Comment 7 Dimitri Glazkov (Google) 2010-09-03 10:05:04 PDT
This doesn't work on Windows though. Fix coming up.