Bug 38553 - new-run-webkit-tests: disable threading on macs by default
Summary: new-run-webkit-tests: disable threading on macs by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 16:17 PDT by Dirk Pranke
Modified: 2010-05-04 18:44 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.19 KB, patch)
2010-05-04 16:25 PDT, Dirk Pranke
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
add log message (2.46 KB, patch)
2010-05-04 16:44 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
add unit tests for the change to run_webkit_tests (6.86 KB, patch)
2010-05-04 17:07 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-05-04 16:17:18 PDT
We are currently trying to diagnose what appear to be several concurrency-related hangs on the Chromium bots. Several bots (Chromium WebKit Mac (webkit.org) canary, Chromium WebKit Mac, Chromium WebKit Mac (dbg)(3) ) seem to be hanging more than 25% of the time.

Until we can diagnose what's going on better, we should consider disabling concurrency by default on the Chromium Mac ports. Most of the bots run two threads in parallel, so this will near-double the cycle time for the layout tests on them.
Comment 1 Eric Seidel (no email) 2010-05-04 16:19:32 PDT
Another possibility would be to try changing DEPS to point to an older version of WebKitTools on those bots and see if the hangs go away.
Comment 2 Dirk Pranke 2010-05-04 16:25:18 PDT
Created attachment 55069 [details]
patch
Comment 3 Eric Seidel (no email) 2010-05-04 16:27:39 PDT
Comment on attachment 55069 [details]
patch

We really should have a unit test for the run_webkit_tests.py change.

This seems OK or now.  Unfortunately it means we'll stop getting crash/hang data, but hopefully we have enough and can repro locally anyway.

Seems we should log to the console when we do this override.
Comment 4 Eric Seidel (no email) 2010-05-04 16:36:50 PDT
Comment on attachment 55069 [details]
patch

Please fix the mentioned nits.  If you aren't going to unit test this we should at least mention why in the ChangeLog.
Comment 5 Dirk Pranke 2010-05-04 16:44:17 PDT
Created attachment 55070 [details]
add log message
Comment 6 Dirk Pranke 2010-05-04 17:07:34 PDT
Created attachment 55075 [details]
add unit tests for the change to run_webkit_tests
Comment 7 Dirk Pranke 2010-05-04 17:17:06 PDT
Committed r58789: <http://trac.webkit.org/changeset/58789>
Comment 8 Eric Seidel (no email) 2010-05-04 18:44:43 PDT
Thanks for the tests!