Bug 44425 - Use the correct library name when compiling with gtk3
Summary: Use the correct library name when compiling with gtk3
Status: RESOLVED DUPLICATE of bug 42026
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 08:03 PDT by Sergio Villar Senin
Modified: 2010-08-25 11:17 PDT (History)
1 user (show)

See Also:


Attachments
Use webkitgtk+-3.0 if available (783 bytes, patch)
2010-08-23 08:08 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2010-08-23 08:03:38 PDT
WebKitGtk+ library name is hardcoded in WebKitTools/Scripts/webkitdirs.pm. It's only valid if gtk2 is used.
Comment 1 Sergio Villar Senin 2010-08-23 08:08:26 PDT
Created attachment 65120 [details]
Use webkitgtk+-3.0 if available

The library name is still hardcoded, but we detect if it was built against gtk3 and use the proper library in that case
Comment 2 WebKit Review Bot 2010-08-23 08:12:30 PDT
Attachment 65120 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitdirs.pm:600:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/Scripts/webkitdirs.pm:601:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/Scripts/webkitdirs.pm:602:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/Scripts/webkitdirs.pm:603:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/Scripts/webkitdirs.pm:604:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sergio Villar Senin 2010-08-23 08:27:57 PDT
actually a dup

*** This bug has been marked as a duplicate of bug 42026 ***
Comment 4 Xan Lopez 2010-08-25 11:17:39 PDT
Comment on attachment 65120 [details]
Use webkitgtk+-3.0 if available

Drop from queue.