WebKitTools/Scripts/webkitdirs.pm line 599 hardcodes libwebkitgtk-1.0.so but if webkit is compiled against gtk3 it should be libwebkitgtk-3.0.so To test: run-launcher --gtk Error: Can't find built framework at "/home/phil/gst/jhbuild/build/WebKit/WebKitBuild/gtk-fullscreen2/Release/JavaScriptCore/../.libs/libwebkitgtk-1.0.so".
Because we support build of gtk2 and gtk3 at the moment I think it'd make sense to have: build-webkit --gtk3 and the current --gtk option (renamed to --gtk2?) instead of build-webkit --gtk --use-gtk=3.0 This be used for the launcher too: run-launcher --gtk2 run-launcher --gtk3
Why not just have the script detect what the appropriate version of the library is, by looking at the directory contents?
(In reply to comment #2) > Why not just have the script detect what the appropriate version of the library is, by looking at the directory contents? You could have both libraries, so a switch might make sense to force one or the other.
True, I think that only if both exist should an extra switch be required to select the right one.
The less intrusive is probably to assume --gtk is for gtk2 (for now) and add a --gtk3 switch. So later on when we drop support for gtk2, just assume --gtk is for gtk3 and drop --gtk3... What ya think? Renaming the current --gtk to --gtk2 would imply we need to update the buildbot scripts at least. It might also confuse the current people who use --gtk.
Created attachment 65114 [details] gtk3build.diff So, let's do first what Martin suggested. It should work well enough for our common work routine, and if anybody needs something more sophisticated he can go ahead and write it.
Comment on attachment 65114 [details] gtk3build.diff LGTM!
*** Bug 44425 has been marked as a duplicate of this bug. ***
Comment on attachment 65114 [details] gtk3build.diff Landed as r65811.
Closing bug.