Bug 44220 - dumpAsMarkup conversion: editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html
Summary: dumpAsMarkup conversion: editing/pasteboard/4242293-1.html and editing/pasteb...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Blocker
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 24009 26483
  Show dependency treegraph
 
Reported: 2010-08-18 17:05 PDT by Ryosuke Niwa
Modified: 2011-08-16 19:56 PDT (History)
5 users (show)

See Also:


Attachments
converts the tests (32.14 KB, patch)
2010-08-18 17:20 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
fixed per Ojan's comment (32.13 KB, patch)
2010-08-18 19:17 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Removed dump-as-markup change (31.25 KB, patch)
2010-08-18 19:19 PDT, Ryosuke Niwa
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-08-18 17:05:36 PDT
editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html should be dumpAsMarkup tests because neither tests need to verify the rendering.
Comment 1 Ryosuke Niwa 2010-08-18 17:20:14 PDT
Created attachment 64792 [details]
converts the tests
Comment 2 Eric Seidel (no email) 2010-08-18 17:33:56 PDT
Comment on attachment 64792 [details]
converts the tests

Are you sure your new editing/pasteboard/4242293-1-expected.txt are right?  The two regions don't match.
Comment 3 Ryosuke Niwa 2010-08-18 17:36:30 PDT
(In reply to comment #2)
> (From update of attachment 64792 [details])
> Are you sure your new editing/pasteboard/4242293-1-expected.txt are right?  The two regions don't match.

Yes.  By identical contents, we mean that they look alike, not identical DOM tree.
Comment 4 Ojan Vafai 2010-08-18 18:19:23 PDT
Comment on attachment 64792 [details]
converts the tests

Can you change the text in 4242293-1.html to say that they should be visually identical? Your change obviously isn't causing the test case to fail.

Also, can you move the dump-as-markup.js change into a separate patch?
Comment 5 Ryosuke Niwa 2010-08-18 18:56:42 PDT
(In reply to comment #4)
> (From update of attachment 64792 [details])
> Can you change the text in 4242293-1.html to say that they should be visually identical? Your change obviously isn't causing the test case to fail.

Will do.

> Also, can you move the dump-as-markup.js change into a separate patch?

Filed the bug 44225.  Will submit a patch shortly.
Comment 6 Ryosuke Niwa 2010-08-18 19:17:45 PDT
Created attachment 64800 [details]
fixed per Ojan's comment
Comment 7 Ryosuke Niwa 2010-08-18 19:19:22 PDT
Created attachment 64801 [details]
Removed dump-as-markup change
Comment 8 Ryosuke Niwa 2010-08-19 15:02:14 PDT
Thanks Tony!
Comment 9 Ryosuke Niwa 2010-08-19 18:22:44 PDT
Committed r65721: <http://trac.webkit.org/changeset/65721>