Bug 44225 - REGRESSION(r64303): dumpAsMarkup doesn't print the output without layoutTestController
Summary: REGRESSION(r64303): dumpAsMarkup doesn't print the output without layoutTestC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 18:55 PDT by Ryosuke Niwa
Modified: 2010-08-19 00:46 PDT (History)
2 users (show)

See Also:


Attachments
fixes the bug (1.50 KB, patch)
2010-08-18 19:04 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-08-18 18:55:09 PDT
After http://trac.webkit.org/changeset/64303/trunk/LayoutTests/resources/dump-as-markup.js, dumpAsMarkup no longer prints the output when opened manually on Safari or other applications.
Comment 1 Ryosuke Niwa 2010-08-18 19:04:49 PDT
Created attachment 64799 [details]
fixes the bug
Comment 2 WebKit Commit Bot 2010-08-18 21:06:54 PDT
Comment on attachment 64799 [details]
fixes the bug

Rejecting patch 64799 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20870 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 14250 tests run.
251.17s total testing time

14249 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3760374
Comment 3 WebKit Commit Bot 2010-08-19 00:46:24 PDT
Comment on attachment 64799 [details]
fixes the bug

Clearing flags on attachment: 64799

Committed r65657: <http://trac.webkit.org/changeset/65657>
Comment 4 WebKit Commit Bot 2010-08-19 00:46:28 PDT
All reviewed patches have been landed.  Closing bug.