Bug 44190 - [Cairo] Eliminate full-surface copy from canvas.drawImage(...)
Summary: [Cairo] Eliminate full-surface copy from canvas.drawImage(...)
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
Keywords: Cairo
Depends on:
Reported: 2010-08-18 11:20 PDT by Martin Robinson
Modified: 2010-08-20 09:02 PDT (History)
2 users (show)

See Also:

Patch for this issue (3.37 KB, patch)
2010-08-18 11:23 PDT, Martin Robinson
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-08-18 11:20:29 PDT
This is the Cairo followup to Dave Hyatt's patch in r65449.           https://bugs.webkit.org/show_bug.cgi?id=44115
Comment 1 Martin Robinson 2010-08-18 11:23:46 PDT
Created attachment 64742 [details]
Patch for this issue
Comment 2 Dirk Schulze 2010-08-19 22:43:35 PDT
Comment on attachment 64742 [details]
Patch for this issue

 +  #include <cmath>
Can you use <wtf/MathExtras.h> here? Think it's better to use the same math include all over WebKit (Also if you want to replace cmath with another math-lib for what ever reason).

 +  void ImageBuffer::clip(GraphicsContext* context, const FloatRect& rect) const
Why did you add the variable names? As long as we don't implement clip, we should leave them out.

Patch looks great. Please change the snippets. r=me.
Comment 3 Martin Robinson 2010-08-20 09:02:22 PDT
Committed r65736: <http://trac.webkit.org/changeset/65736>