RESOLVED FIXED 44190
[Cairo] Eliminate full-surface copy from canvas.drawImage(...) 
https://bugs.webkit.org/show_bug.cgi?id=44190
Summary [Cairo] Eliminate full-surface copy from canvas.drawImage(...)
Martin Robinson
Reported 2010-08-18 11:20:29 PDT
This is the Cairo followup to Dave Hyatt's patch in r65449. https://bugs.webkit.org/show_bug.cgi?id=44115
Attachments
Patch for this issue (3.37 KB, patch)
2010-08-18 11:23 PDT, Martin Robinson 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-08-18 11:23:46 PDT
Created attachment 64742 [details] Patch for this issue
Dirk Schulze
Comment 2 2010-08-19 22:43:35 PDT
Comment on attachment 64742 [details] Patch for this issue WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:42 + #include <cmath> Can you use <wtf/MathExtras.h> here? Think it's better to use the same math include all over WebKit (Also if you want to replace cmath with another math-lib for what ever reason). WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:111 + void ImageBuffer::clip(GraphicsContext* context, const FloatRect& rect) const Why did you add the variable names? As long as we don't implement clip, we should leave them out. Patch looks great. Please change the snippets. r=me.
Martin Robinson
Comment 3 2010-08-20 09:02:22 PDT
Committed r65736: <http://trac.webkit.org/changeset/65736>
Note You need to log in before you can comment on or make changes to this bug.