Bug 44115 – [CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas, ...) path.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Stephen White]

[CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas, ...) path.

[Stephen White]

Created attachment 64602 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 64602 [details]
Patch

WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h:82
 +      BitmapImageSingleFrameSkia(const SkBitmap&);
should this be marked 'explicit' just in case?

WebCore/platform/graphics/skia/NativeImageSkia.h:49
 +      NativeImageSkia(const SkBitmap&);
nit: mark this 'explicit'?

R=me

[Stephen White]

(In reply to comment #2)
> (From update of attachment 64602 [details])
> WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h:82
>  +      BitmapImageSingleFrameSkia(const SkBitmap&);
> should this be marked 'explicit' just in case?
> 
> WebCore/platform/graphics/skia/NativeImageSkia.h:49
>  +      NativeImageSkia(const SkBitmap&);
> nit: mark this 'explicit'?

Good idea.  Will do before landing.

> 
> R=me

[Stephen White]

Committed r65528: <http://trac.webkit.org/changeset/65528>

[Stephen White]

Rolled out in https://bugs.webkit.org/show_bug.cgi?id=44123 due to test failures; reopening.

[Stephen White]

Created attachment 64627 [details]
Patch

[Stephen White]

Should fix the test failures (they go from 80 -> 40 on my Win7 box, which is about normal these days :| ).

[Darin Fisher (:fishd, Google)]

Comment on attachment 64627 [details]
Patch

R=me, but same comment about adding the 'explicit' keyword.

[Stephen White]

Committed r65617: <http://trac.webkit.org/changeset/65617>

[WebKit Review Bot]

http://trac.webkit.org/changeset/65617 might have broken GTK Linux 32-bit Release