Bug 44156 – [Chromium] Remove rebaselined results for "fast/events/special-key-events-in-input-text.html"

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Hironori Bono]

Greetings,

The test_shell of Chromium can yield the same output as "LayoutTests/fast/events/fast/events/special-key-events-in-input-text-expected.txt" on Windows and Mac when I land my test_shell change <http://codereview.chromium.org/3037053>. Therefore, we do not need rebaselined outputs for them any longer.

Regards,

Hironori Bono

[Hironori Bono]

Created attachment 65075 [details]
Proposed patch #1

[Kent Tamura]

Comment on attachment 65075 [details]
Proposed patch #1

OK.

[WebKit Commit Bot]

Comment on attachment 65075 [details]
Proposed patch #1

Clearing flags on attachment: 65075

Committed r65812: <http://trac.webkit.org/changeset/65812>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[James Robinson]

This test now fails on every platform in Chromium.  http://test-results.appspot.com/dashboards/flakiness_dashboard.html#useWebKitCanary=true&tests=fast%2Fevents%2Fspecial-key-events-in-input-text.html

[Kent Tamura]

Oh, I thought the test_shell change was already committed.

Bono-san, please add a LayoutTests/platform/chromium/test_expectations.txt change to this patch so that it contains "BUGWK44156 : fast/events/special-key-events-in-input-text.html = TEXT".
You should commit the test_shell change after a WebKit roll containing this change.

[Kent Tamura]

(In reply to comment #6)
> Bono-san, please add a LayoutTests/platform/chromium/test_expectations.txt change to this patch so that it contains "BUGWK44156 : fast/events/special-key-events-in-input-text.html = TEXT".

BUG51036 : fast/events/special-key-events-in-input-text.html = TEXT
is better.

[Hironori Bono]

Created attachment 65203 [details]
Proposed patch #2

Thank you for your review and sorry for the test break caused by my change.

(In reply to comment #6)
> Oh, I thought the test_shell change was already committed.

Sorry for the lack of my explanation. When I talked in IRC, it is better to remove these rebaselined results before landing my test_shell change (*1). I will land it after this change is merged to Chrome.

(*1) http://codereview.chromium.org/3037053

(In reply to comment #7)
a> > Bono-san, please add a LayoutTests/platform/chromium/test_expectations.txt change to this patch so that it contains "BUGWK44156 : fast/events/special-key-events-in-input-text.html = TEXT".
> 
> BUG51036 : fast/events/special-key-events-in-input-text.html = TEXT
> is better.

Done. I forgot changing the test expectation. Thank you for noticing this.

Regards,

Hironori Bono

[WebKit Commit Bot]

Comment on attachment 65203 [details]
Proposed patch #2

Clearing flags on attachment: 65203

Committed r65865: <http://trac.webkit.org/changeset/65865>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.