Bug 51036 - [GTK] Unsigned values substraction bug in SoupCache
Summary: [GTK] Unsigned values substraction bug in SoupCache
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-14 07:15 PST by Michal Pakula vel Rutka
Modified: 2010-12-15 02:36 PST (History)
4 users (show)

See Also:


Attachments
[GTK] Unsigned values substraction bug in SoupCache (1.50 KB, patch)
2010-12-14 07:30 PST, Michal Pakula vel Rutka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2010-12-14 07:15:44 PST
There is bug soup-http-input-stream.c in function webkit_soup_http_input_stream_got_chunk at line 270:

if (priv->caller_bufsize - priv->caller_nread > 0) {

as both of values type is gsize which unsigned int it always will be greater than zero when values are different.
Comment 1 Michal Pakula vel Rutka 2010-12-14 07:30:41 PST
Created attachment 76534 [details]
[GTK] Unsigned values substraction bug in SoupCache
Comment 2 Sergio Villar Senin 2010-12-14 11:43:58 PST
The bug indeed exists but I have already fixed it in libsoup as the SoupCache code was imported there during this year's hackfest. I don't think it makes sense to fix it in WebKit as the SoupCache code will be removed soon.
Comment 3 Martin Robinson 2010-12-14 11:57:07 PST
Thanks for the update Sergio. There's no point fixing this as the code will be nuked soon.
Comment 4 Michal Pakula vel Rutka 2010-12-14 23:20:12 PST
OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen?
Comment 5 Sergio Villar Senin 2010-12-15 00:57:14 PST
(In reply to comment #4)
> OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen?

We're waiting for Google guys to update the EWS bots
Comment 6 Xan Lopez 2010-12-15 02:36:36 PST
Comment on attachment 76534 [details]
[GTK] Unsigned values substraction bug in SoupCache

Removing from review queue.