RESOLVED WONTFIX 51036
[GTK] Unsigned values substraction bug in SoupCache 
https://bugs.webkit.org/show_bug.cgi?id=51036
Summary [GTK] Unsigned values substraction bug in SoupCache
Michal Pakula vel Rutka
Reported 2010-12-14 07:15:44 PST
There is bug soup-http-input-stream.c in function webkit_soup_http_input_stream_got_chunk at line 270: if (priv->caller_bufsize - priv->caller_nread > 0) { as both of values type is gsize which unsigned int it always will be greater than zero when values are different.
Attachments
[GTK] Unsigned values substraction bug in SoupCache (1.50 KB, patch)
2010-12-14 07:30 PST, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michal Pakula vel Rutka
Comment 1 2010-12-14 07:30:41 PST
Created attachment 76534 [details] [GTK] Unsigned values substraction bug in SoupCache
Sergio Villar Senin
Comment 2 2010-12-14 11:43:58 PST
The bug indeed exists but I have already fixed it in libsoup as the SoupCache code was imported there during this year's hackfest. I don't think it makes sense to fix it in WebKit as the SoupCache code will be removed soon.
Martin Robinson
Comment 3 2010-12-14 11:57:07 PST
Thanks for the update Sergio. There's no point fixing this as the code will be nuked soon.
Michal Pakula vel Rutka
Comment 4 2010-12-14 23:20:12 PST
OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen?
Sergio Villar Senin
Comment 5 2010-12-15 00:57:14 PST
(In reply to comment #4) > OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen? We're waiting for Google guys to update the EWS bots
Xan Lopez
Comment 6 2010-12-15 02:36:36 PST
Comment on attachment 76534 [details] [GTK] Unsigned values substraction bug in SoupCache Removing from review queue.
Note You need to log in before you can comment on or make changes to this bug.