Implement blur support for shadow of rectangles. Shadow pixel tests need to be updated, too.
Created attachment 64463 [details] Patch
Created attachment 64469 [details] Patch
Comment on attachment 64469 [details] Patch Looks good to me, some minor nits below. WebCore/platform/graphics/qt/ContextShadow.cpp:70 + #define BLUR_SUM_SHIFT 14 Why not use a static const? WebCore/platform/graphics/qt/ContextShadow.cpp:72 + // Note: image must be RGB32 format You could add an assert for that, I guess WebCore/platform/graphics/qt/ContextShadow.cpp:88 + why this extra newline? WebCore/platform/graphics/qt/ContextShadow.cpp:91 + int left, right, pixelCount, prev, next; We normally do not add most variable declarations on the same line. WebCore/platform/graphics/qt/ContextShadow.cpp:128 + ((prev > 0) ? *prevPtr : firstAlpha); why not just keep on one line :-) I guess it is shorter than the above for-one. WebCore/platform/graphics/qt/ContextShadow.cpp:154 + // Step 3: blur green channel and store the result in the alpha channel Add a dot at the end of the comment. WebCore/platform/graphics/qt/ContextShadow.cpp:190 + // "colorize" with the right shadow color here as well WebCore/platform/graphics/qt/ContextShadow.cpp:220 + } Here we shouldnt use braces according to the coding style guide
Manually committed r65425: http://trac.webkit.org/changeset/65425
Comment on attachment 64469 [details] Patch Clearing the review flag.