Bug 44015 - [Qt] Border should not cast shadows
Summary: [Qt] Border should not cast shadows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ariya Hidayat
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 34479 44025 44031
  Show dependency treegraph
 
Reported: 2010-08-14 13:54 PDT by Ariya Hidayat
Modified: 2010-08-15 22:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (48.49 KB, patch)
2010-08-14 15:21 PDT, Ariya Hidayat
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-08-14 13:54:09 PDT
Border does not need to cast shadows by itself, it's already handled as part of the box. For example, a div with a dotted border casts a rectangular shadow, without extra dots surrounding the rectangle.

This behavior was first introduced in http://trac.webkit.org/changeset/34763.
Comment 1 Ariya Hidayat 2010-08-14 15:06:21 PDT
And due to http://trac.webkit.org/changeset/47103, too.
Comment 2 Ariya Hidayat 2010-08-14 15:21:50 PDT
Created attachment 64430 [details]
Patch
Comment 3 Antonio Gomes 2010-08-15 21:20:40 PDT
Comment on attachment 64430 [details]
Patch

Nice step forward to bug 44025!
Comment 4 Ariya Hidayat 2010-08-15 22:27:50 PDT
Comment on attachment 64430 [details]
Patch

Clearing flags on attachment: 64430

Committed r65392: <http://trac.webkit.org/changeset/65392>
Comment 5 Ariya Hidayat 2010-08-15 22:27:56 PDT
All reviewed patches have been landed.  Closing bug.