Bug 43918 - REGRESSION(r65225): Broke EFL port build (Requested by acidx on #webkit).
Summary: REGRESSION(r65225): Broke EFL port build (Requested by acidx on #webkit).
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
Depends on:
Blocks: 39164
  Show dependency treegraph
Reported: 2010-08-12 08:04 PDT by WebKit Review Bot
Modified: 2010-08-12 11:29 PDT (History)
5 users (show)

See Also:

ROLLOUT of r65225 (8.07 KB, patch)
2010-08-12 08:04 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-08-12 08:04:35 PDT
http://trac.webkit.org/changeset/65225 broke the build:
Broke EFL port build (Requested by acidx on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-08-12 08:04:48 PDT
Created attachment 64226 [details]
ROLLOUT of r65225

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2010-08-12 08:12:17 PDT
Comment on attachment 64226 [details]
ROLLOUT of r65225

Clearing flags on attachment: 64226

Committed r65246: <http://trac.webkit.org/changeset/65246>
Comment 3 WebKit Commit Bot 2010-08-12 08:12:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Jeremy Orlow 2010-08-12 08:17:58 PDT
I don't see why this was rolled out.  If you caught a real regression, that'd be one thing, but simply breaking your build isn't a good reason until you have a build bot on build.webkit.org.  Until then, there's no way for another port to know they broke you or figure out how to not break you.
Comment 5 Patrick R. Gansterer 2010-08-12 08:33:18 PDT
A buildproblem is not a real regression and doesn't need a rollout.
Can you please explain the problem?
Comment 6 Eric Seidel (no email) 2010-08-12 11:26:06 PDT
Isn't efl the only port which uses cmake?  I don't see anything wrong with this rollout. But maybe I'm reading wrong?
Comment 7 Patrick R. Gansterer 2010-08-12 11:29:49 PDT
(In reply to comment #6)
> Isn't efl the only port which uses cmake?
I use it for WinCE too, but it's not in trunk yet. The rollout is correct. I (and other people on IRC) don't know why this happend. ChangeLog doesn't mention and there is no buildbot in the moment to see the buildproblem.