Bug 43856 – Perl warnings when running commit-log-editor

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Following the patch for Bug #40548 (committed in changeset 65148 <http://trac.webkit.org/changeset/65148>), when running the commit-log-editor Perl complains with the following warnings:

Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85.
Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86.
Bareword "true" not allowed while "strict subs" in use at ./commit-log-editor line 68.
Bareword "false" not allowed while "strict subs" in use at ./commit-log-editor line 73.
Bareword "false" not allowed while "strict subs" in use at ./commit-log-editor line 80.
Bareword "false" not allowed while "strict subs" in use at ./commit-log-editor line 87.
Execution of ./commit-log-editor aborted due to compilation errors.

[Daniel Bates]

Created attachment 64123 [details]
Patch

Perl doesn't have symbolic names for True/False. Instead, we should use boolean values. Moreover, the variable installedEditorApplication is unused. It looks like it should be renamed builtEditorApplication so that it uses the existing machinery to set the editor.

[Dave Hyatt]

This patch addresses some of the errors, but not these:

"Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85.
Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86."

I still can't commit. Help!

[Daniel Bates]

Committed in changeset 65179 <http://trac.webkit.org/changeset/65179>.

[Daniel Bates]

Comment on attachment 64123 [details]
Patch

Clearing commit-queue flag since I committed this by hand because the queue was slow today :-(

[Daniel Bates]

(In reply to comment #2)
> This patch addresses some of the errors, but not these:
> 
> "Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85.
> Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86."
> 
> I still can't commit. Help!

Spoke with David Hyatt on IRC. He inadvertently did not copy over the change to rename the variable installedEditorApplication to builtEditorApplication (included in this patch). He confirmed that his change resolves the "Global symbol" warnings.