Bug 40548 – Improved editor options for prepare-ChangeLog and commit-log-editor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Darin Adler]

Improved editor options for prepare-ChangeLog and commit-log-editor

[Darin Adler]

Created attachment 58600 [details]
Patch

[Darin Adler]

*** Bug 40756 has been marked as a duplicate of this bug. ***

[Kenneth Rohde Christiansen]

Comment on attachment 58600 [details]
Patch

WebKitTools/Scripts/commit-log-editor:92
 +  $editor = "/usr/bin/vi" if !$editor;
Should this really be hardcoded? why not just use vi from your PATH?

[Darin Adler]

(In reply to comment #3)
> (From update of attachment 58600 [details])
> WebKitTools/Scripts/commit-log-editor:92
>  +  $editor = "/usr/bin/vi" if !$editor;
> Should this really be hardcoded? why not just use vi from your PATH?

Generally speaking we don't rely on PATH for the tools. It’s not something I feel passionate about. It’s been like this for about 8 years and I wasn’t looking to change it.

[John Sullivan]

Comment on attachment 58600 [details]
Patch

Poor li'l patch, wasting away for so long!

[Joseph Pecoraro]

Comment on attachment 58600 [details]
Patch

> +        values like "xed --launch --wait" work propertly.

Typo in the ChangeLog could be fixed: "propertly" => "properly"

[Adam Barth]

Created attachment 64071 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 64071 [details]
Patch for landing

Clearing flags on attachment: 64071

Committed r65148: <http://trac.webkit.org/changeset/65148>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

(In reply to comment #9)
> All reviewed patches have been landed.  Closing bug.

For historical preservation, this change caused some Perl warnings. These warnings were resolved in Bug #43856.