RESOLVED DUPLICATE of bug 3267943810
Commit-queue shouldn't land patch if cq+ was removed 
https://bugs.webkit.org/show_bug.cgi?id=43810
Summary Commit-queue shouldn't land patch if cq+ was removed
Csaba Osztrogonác
Reported 2010-08-10 14:41:33 PDT
If you set cq+ for a patch, commit queue script will add it to the commit queue. But if you realise later that you shouldn't have set cq+ and then you remove it (or set cq-), the script will land the patch irrespectively of the new cq flag. I think cq ignores modified flag only after it started landing. Otherwise it removes the patch from the queue correctly. I propose commit queue should check cq flag again after build&test finished and before landing to avoid this unwanted commit.
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-08-10 14:44:00 PDT
This is an old bug. :( *** This bug has been marked as a duplicate of bug 32679 ***
Csaba Osztrogonác
Comment 2 2010-08-10 14:47:24 PDT
(In reply to comment #1) > This is an old bug. :( > > *** This bug has been marked as a duplicate of bug 32679 *** Good to know, thanks. I will search in bugzilla next time.
Adam Barth
Comment 3 2010-08-10 15:26:50 PDT
BTW, this bug isn't too hard to fix. You just need to add a precommit callback to the parent command class to see if it wants to abort and then have CommitQueue implement logic to check the flag before landing. You can see how we do other --parent-command callbacks.
Note You need to log in before you can comment on or make changes to this bug.