RESOLVED FIXED 32679
commit-queue should check commit-queue+ again just before committing 
https://bugs.webkit.org/show_bug.cgi?id=32679
Summary commit-queue should check commit-queue+ again just before committing
Eric Seidel (no email)
Reported 2009-12-17 14:44:46 PST
commit-queue should check commit-queue+ again just before committing Right now once you set commit-queue+ once the bot sees your cq+ (which could be immediately, or could be hours from now), the moment it starts the landing process, it can't be stopped, except by my intervention. We should make it check the bug to validate that the patch is still cq+ just before doing the actual commit. This makes it possible for people to cancel commits more reliably.
Attachments
Patch (20.60 KB, patch)
2010-09-20 12:53 PDT, Eric Seidel (no email) 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-17 14:50:05 PST
It could also check to make sure the bots are still green just before committing.
Eric Seidel (no email)
Comment 2 2010-08-10 14:44:00 PDT
*** Bug 43810 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 3 2010-09-20 12:53:11 PDT
Created attachment 68125 [details] Patch
Adam Barth
Comment 4 2010-09-20 13:00:17 PDT
Comment on attachment 68125 [details] Patch great. :)
WebKit Commit Bot
Comment 5 2010-09-20 13:49:33 PDT
Comment on attachment 68125 [details] Patch Clearing flags on attachment: 68125 Committed r67880: <http://trac.webkit.org/changeset/67880>
WebKit Commit Bot
Comment 6 2010-09-20 13:49:39 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2010-09-20 13:53:46 PDT
Comment on attachment 68125 [details] Patch Rejecting patch 68125 from commit-queue. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Last 500 characters of output: atching file WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py Hunk #1 FAILED at 45. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py.rej patching file WebKitTools/Scripts/webkitpy/tool/mocktool.py Hunk #1 FAILED at 161. Hunk #2 FAILED at 170. Hunk #3 FAILED at 179. Hunk #4 FAILED at 188. Hunk #5 FAILED at 258. Hunk #6 FAILED at 281. 6 out of 6 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/mocktool.py.rej Full output: http://queues.webkit.org/results/4099004
Eric Seidel (no email)
Comment 8 2010-09-20 14:05:38 PDT
The irony!
Note You need to log in before you can comment on or make changes to this bug.