Bug 32679 - commit-queue should check commit-queue+ again just before committing
Summary: commit-queue should check commit-queue+ again just before committing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
: 43810 (view as bug list)
Depends on:
Blocks: 46138
  Show dependency treegraph
Reported: 2009-12-17 14:44 PST by Eric Seidel (no email)
Modified: 2010-09-20 17:05 PDT (History)
4 users (show)

See Also:

Patch (20.60 KB, patch)
2010-09-20 12:53 PDT, Eric Seidel (no email)
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-17 14:44:46 PST
commit-queue should check commit-queue+ again just before committing

Right now once you set commit-queue+ once the bot sees your cq+ (which could be immediately, or could be hours from now), the moment it starts the landing process, it can't be stopped, except by my intervention.  We should make it check the bug to validate that the patch is still cq+ just before doing the actual commit.  This makes it possible for people to cancel commits more reliably.
Comment 1 Eric Seidel (no email) 2009-12-17 14:50:05 PST
It could also check to make sure the bots are still green just before committing.
Comment 2 Eric Seidel (no email) 2010-08-10 14:44:00 PDT
*** Bug 43810 has been marked as a duplicate of this bug. ***
Comment 3 Eric Seidel (no email) 2010-09-20 12:53:11 PDT
Created attachment 68125 [details]
Comment 4 Adam Barth 2010-09-20 13:00:17 PDT
Comment on attachment 68125 [details]

great.  :)
Comment 5 WebKit Commit Bot 2010-09-20 13:49:33 PDT
Comment on attachment 68125 [details]

Clearing flags on attachment: 68125

Committed r67880: <http://trac.webkit.org/changeset/67880>
Comment 6 WebKit Commit Bot 2010-09-20 13:49:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2010-09-20 13:53:46 PDT
Comment on attachment 68125 [details]

Rejecting patch 68125 from commit-queue.

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
atching file WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py
Hunk #1 FAILED at 45.
1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py.rej
patching file WebKitTools/Scripts/webkitpy/tool/mocktool.py
Hunk #1 FAILED at 161.
Hunk #2 FAILED at 170.
Hunk #3 FAILED at 179.
Hunk #4 FAILED at 188.
Hunk #5 FAILED at 258.
Hunk #6 FAILED at 281.
6 out of 6 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/mocktool.py.rej

Full output: http://queues.webkit.org/results/4099004
Comment 8 Eric Seidel (no email) 2010-09-20 14:05:38 PDT
The irony!