commit-queue should check commit-queue+ again just before committing Right now once you set commit-queue+ once the bot sees your cq+ (which could be immediately, or could be hours from now), the moment it starts the landing process, it can't be stopped, except by my intervention. We should make it check the bug to validate that the patch is still cq+ just before doing the actual commit. This makes it possible for people to cancel commits more reliably.
It could also check to make sure the bots are still green just before committing.
*** Bug 43810 has been marked as a duplicate of this bug. ***
Created attachment 68125 [details] Patch
Comment on attachment 68125 [details] Patch great. :)
Comment on attachment 68125 [details] Patch Clearing flags on attachment: 68125 Committed r67880: <http://trac.webkit.org/changeset/67880>
All reviewed patches have been landed. Closing bug.
Comment on attachment 68125 [details] Patch Rejecting patch 68125 from commit-queue. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Last 500 characters of output: atching file WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py Hunk #1 FAILED at 45. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py.rej patching file WebKitTools/Scripts/webkitpy/tool/mocktool.py Hunk #1 FAILED at 161. Hunk #2 FAILED at 170. Hunk #3 FAILED at 179. Hunk #4 FAILED at 188. Hunk #5 FAILED at 258. Hunk #6 FAILED at 281. 6 out of 6 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/mocktool.py.rej Full output: http://queues.webkit.org/results/4099004
The irony!