Bug 43611 - noembed should respect whether plugins are enabled
Summary: noembed should respect whether plugins are enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 00:10 PDT by Adam Barth
Modified: 2010-08-06 11:01 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.00 KB, patch)
2010-08-06 00:12 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-06 00:10:40 PDT 
noembed should respect whether plugins are enabled
Comment 1 Adam Barth 2010-08-06 00:12:43 PDT 
Created attachment 63702 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-08-06 10:36:20 PDT 
Comment on attachment 63702 [details]
Patch

WebCore/html/HTMLTreeBuilder.h:195
 +      static bool scriptEnabled(Frame* frame);
No need for the argument name.

Please file a bug with the HTML5 spec.
Comment 3 Eric Seidel (no email) 2010-08-06 10:36:45 PDT 
Oh, it's possible to test this via DRT.  With layoutTestController.overridePreference()
Comment 4 Eric Seidel (no email) 2010-08-06 10:37:04 PDT 
Comment on attachment 63702 [details]
Patch

This should have a layout test. :)
Comment 5 WebKit Commit Bot 2010-08-06 10:58:34 PDT 
Comment on attachment 63702 [details]
Patch

Clearing flags on attachment: 63702

Committed r64858: <http://trac.webkit.org/changeset/64858>
Comment 6 WebKit Commit Bot 2010-08-06 10:58:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Seidel (no email) 2010-08-06 11:01:51 PDT 
Sigh.  This is an age-old bug: https://bugs.webkit.org/show_bug.cgi?id=32679