Bug 43353 - generate-bindings.pl should generate warning free code
Summary: generate-bindings.pl should generate warning free code
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 43191
  Show dependency treegraph
Reported: 2010-08-02 08:39 PDT by Csaba Osztrogonác
Modified: 2010-08-12 14:56 PDT (History)
5 users (show)

See Also:

proposed fix (1.45 KB, patch)
2010-08-12 09:43 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-08-02 08:39:58 PDT
WebCore/generated/JSBlobBuilder.cpp is generated by WebCore/bindings/scripts/generate-bindings.pl,
and gcc-4.3.2 reports this warning:
generated/JSBlobBuilder.cpp: In function ‘JSC::EncodedJSValue WebCore::jsBlobBuilderPrototypeFunctionAppend(JSC::ExecState*)’:
generated/JSBlobBuilder.cpp:255: warning: suggest parentheses around && within ||

if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info))))

generate-bindings.pl should generate this line:
if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || (exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info)))))
Comment 1 Csaba Osztrogonác 2010-08-12 09:29:36 PDT
I cc-ed Darin, Eric and Anders, you may help to solve this bug, because 
you know generate-bindings.pl from the beginning: https://bugs.webkit.org/show_bug.cgi?id=5975
Comment 2 Csaba Osztrogonác 2010-08-12 09:31:08 PDT
I think I found it, patch is coming soon.
Comment 3 Csaba Osztrogonác 2010-08-12 09:43:23 PDT
Created attachment 64230 [details]
proposed fix
Comment 4 WebKit Commit Bot 2010-08-12 14:56:09 PDT
Comment on attachment 64230 [details]
proposed fix

Clearing flags on attachment: 64230

Committed r65269: <http://trac.webkit.org/changeset/65269>
Comment 5 WebKit Commit Bot 2010-08-12 14:56:14 PDT
All reviewed patches have been landed.  Closing bug.