See http://doc.trolltech.com/4.6/qscriptvalue.html#data http://doc.trolltech.com/4.6/qscriptvalue.html#setData
Created attachment 62814 [details] Fix v1
Comment on attachment 62814 [details] Fix v1 > + [Qt] QScriptValue should hhave API for accessing a private data. Typo at "hhave". > + QExplicitlySharedDataPointer<QScriptValuePrivate> m_objectData; Can't you use the new QSharedPointer instead? > +QScriptValuePrivate* QScriptValuePrivate::data() const > +{ > + if (m_objectData) > + return m_objectData.data(); > + return new QScriptValuePrivate(); > +} Is this asking for a leak? If there is a way to use QSharedPointer, we can even pass QSharedPointer back instead of raw pointer? r- for these minor issues. Otherwise LGTM.
Porting QtScript API over JSC C API will not be continued.