Bug 43115 - [Qt] QScriptValue should hhave API for accessing a private data.
Summary: [Qt] QScriptValue should hhave API for accessing a private data.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31863
  Show dependency treegraph
 
Reported: 2010-07-28 05:13 PDT by Jędrzej Nowacki
Modified: 2011-07-07 07:52 PDT (History)
3 users (show)

See Also:


Attachments
Fix v1 (6.32 KB, patch)
2010-07-28 05:16 PDT, Jędrzej Nowacki
ariya.hidayat: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Jędrzej Nowacki 2010-07-28 05:16:15 PDT
Created attachment 62814 [details]
Fix v1
Comment 2 Ariya Hidayat 2010-08-08 12:51:07 PDT
Comment on attachment 62814 [details]
Fix v1

> +        [Qt] QScriptValue should hhave API for accessing a private data.

Typo at "hhave".

> +    QExplicitlySharedDataPointer<QScriptValuePrivate> m_objectData;

Can't you use the new QSharedPointer instead?

> +QScriptValuePrivate* QScriptValuePrivate::data() const
> +{
> +    if (m_objectData)
> +        return m_objectData.data();
> +    return new QScriptValuePrivate();
> +}

Is this asking for a leak? If there is a way to use QSharedPointer, we can even pass QSharedPointer back instead of raw pointer?

r- for these minor issues. Otherwise LGTM.
Comment 3 Jędrzej Nowacki 2011-07-07 07:52:58 PDT
Porting QtScript API over JSC C API will not be continued.