43073 – Pick up spec change w.r.t. replacement character and <frameset>

Bug 43073 - Pick up spec change w.r.t. replacement character and <frameset>

Summary: Pick up spec change w.r.t. replacement character and <frameset>

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Other OS X 10.5

Importance:	P2 Normal
Assignee:	Adam Barth

URL:
Keywords:

Depends on:
Blocks:	41123
	Show dependency tree / graph

Reported:	2010-07-27 13:29 PDT by Adam Barth
Modified:	2010-08-05 00:04 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (4.78 KB, patch) 2010-07-27 13:30 PDT, Adam Barth	no flags	Details \| Formatted Diff \| Diff
Patch (5.34 KB, patch) 2010-08-04 17:23 PDT, Adam Barth	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adam Barth 2010-07-27 13:29:28 PDT

Pick up spec change w.r.t. replacement character and <frameset>

Comment 1 Adam Barth 2010-07-27 13:30:47 PDT

Created attachment 62736 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-07-27 13:36:23 PDT

Comment on attachment 62736 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:76
 +  inline bool hasSpecialCharacter(const String& string)
hasNonSpecialCharacter?

Your names are confusing here.

Comment 3 Adam Barth 2010-07-27 13:44:55 PDT

Comment on attachment 62736 [details]
Patch

Yeah, sorry, I dropped the not in the name by accident.

Comment 4 Adam Barth 2010-08-04 17:23:18 PDT

Created attachment 63517 [details]
Patch

Comment 5 Eric Seidel (no email) 2010-08-04 17:31:04 PDT

Comment on attachment 63517 [details]
Patch

OK.

Comment 6 Adam Barth 2010-08-04 17:34:51 PDT

Comment on attachment 63517 [details]
Patch

Clearing flags on attachment: 63517

Committed r64698: <http://trac.webkit.org/changeset/64698>

Comment 7 Adam Barth 2010-08-04 17:34:58 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Alexey Proskuryakov 2010-08-05 00:02:00 PDT

+        Pick up spec change w.r.t. replacement character and <frameset>
+        https://bugs.webkit.org/show_bug.cgi?id=43073

I would really appreciate a more detailed ChangeLog - there is no easy way to find out what changed here!

Comment 9 Adam Barth 2010-08-05 00:04:39 PDT

There was a discussion in the HTML WG and they decided to allow the <frameset> element to appear after replacement characters for compatibility with some home routers.  They behavior change is documented in the tests.  The "why" is because the WG said so.  There's not much else to say, IMHO.