Bug 42923 - Re-order whitespace checks in the tokenizer
Summary: Re-order whitespace checks in the tokenizer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-23 18:19 PDT by Adam Barth
Modified: 2010-07-24 13:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.23 KB, patch)
2010-07-23 18:20 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-23 18:19:37 PDT 
Re-order whitespace checks in the tokenizer
Comment 1 Adam Barth 2010-07-23 18:20:32 PDT 
Created attachment 62482 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-23 20:05:19 PDT 
Comment on attachment 62482 [details]
Patch

Interesting.  Again, would be nice to have a comment about why they're in this order.
Comment 3 Adam Barth 2010-07-23 20:15:52 PDT 
Comment on attachment 62482 [details]
Patch

There's an extensive comment in ASCIIType.h that explains the proper order and has statistics.
Comment 4 WebKit Commit Bot 2010-07-24 03:04:22 PDT 
Comment on attachment 62482 [details]
Patch

Rejecting patch 62482 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20715 test cases.
animations/play-state.html -> failed

Exiting early after 1 failures. 123 tests run.
11.51s total testing time

122 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://queues.webkit.org/results/3567416
Comment 5 Eric Seidel (no email) 2010-07-24 07:51:16 PDT 
Comment on attachment 62482 [details]
Patch

Bug 42821.
Comment 6 WebKit Commit Bot 2010-07-24 13:02:48 PDT 
Comment on attachment 62482 [details]
Patch

Clearing flags on attachment: 62482

Committed r64012: <http://trac.webkit.org/changeset/64012>
Comment 7 WebKit Commit Bot 2010-07-24 13:02:53 PDT 
All reviewed patches have been landed.  Closing bug.