RESOLVED FIXED 42921
Save a per-character branch in the HTML parser 
https://bugs.webkit.org/show_bug.cgi?id=42921
Summary Save a per-character branch in the HTML parser
Adam Barth
Reported 2010-07-23 17:56:31 PDT
Save a per-character branch in the HTML parser
Attachments
Patch (3.30 KB, patch)
2010-07-23 17:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-23 17:58:03 PDT
Created attachment 62479 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-23 20:09:03 PDT
Comment on attachment 62479 [details] Patch So I'm confused by the m_data.clear()s being moved to .clear(). When is ::clear() called? I guess either the branch isn't actually that hot, or branch prediction is just winning out here.
Adam Barth
Comment 3 2010-07-23 20:17:57 PDT
> So I'm confused by the m_data.clear()s being moved to .clear(). When is ::clear() called? Clear is called by the HTMLDocumentParser after each token. It reset the token. Before we were using lazy clearing where we delayed zeroing everything out until we started a new token. I want to get rid of the branch, so i made this eager. > I guess either the branch isn't actually that hot, or branch prediction is just winning out here. Probably. Or maybe moving the clear is costing us. In any case, I think this is prettier.
WebKit Commit Bot
Comment 4 2010-07-23 21:42:29 PDT
Comment on attachment 62479 [details] Patch Rejecting patch 62479 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20715 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 12.72s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3623012
Eric Seidel (no email)
Comment 5 2010-07-24 07:53:27 PDT
Comment on attachment 62479 [details] Patch Bug 42821, again.
WebKit Commit Bot
Comment 6 2010-07-24 10:07:47 PDT
Comment on attachment 62479 [details] Patch Rejecting patch 62479 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20715 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 11.55s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3572410
Eric Seidel (no email)
Comment 7 2010-07-24 10:15:11 PDT
Comment on attachment 62479 [details] Patch Broken animation test. :(
Adam Barth
Comment 8 2010-07-24 10:21:38 PDT
The failure rate on that test is out of control. Can we do something about it?
WebKit Commit Bot
Comment 9 2010-07-24 10:33:24 PDT
Comment on attachment 62479 [details] Patch Clearing flags on attachment: 62479 Committed r64010: <http://trac.webkit.org/changeset/64010>
WebKit Commit Bot
Comment 10 2010-07-24 10:33:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.