Bug 42813 – [EFL] Build break for SVN r63881

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Build break on r63881.

Linking CXX executable ../Programs/EWebLauncher
libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal(WebCore::String const&)'
libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess(WebCore::String const&)'
libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure(WebCore::String const&)'
libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLAsLocal(WebCore::String const&)'
collect2: ld returned 1 exit status

[Gyuyoung Kim]

Created attachment 62281 [details]
Patch

[Gyuyoung Kim]

Created attachment 62282 [details]
Patch

Sorry. wrong file was uploaded.

[Leandro Pereira]

Comment on attachment 62282 [details]
Patch

LGTM. Since it is a bug fix, I'm commit-queuing this without a formal review.

[Leandro Pereira]

(In reply to comment #3)
> (From update of attachment 62282 [details])
> LGTM. Since it is a bug fix, I'm commit-queuing this without a formal review.

And by "bug fix", I meant *build* fix.

[Antonio Gomes]

Comment on attachment 62282 [details]
Patch

Not sure if the commit-queue understands cq+ for "unreviewed build fix" patches.

Lets try r+'ing it.

[Antonio Gomes]

Comment on attachment 62282 [details]
Patch

Lets try without r+

[Leandro Pereira]

Comment on attachment 62282 [details]
Patch

Clearing flags on attachment: 62282

Committed r63894: <http://trac.webkit.org/changeset/63894>

[Leandro Pereira]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Comment on attachment 62282 [details]
Patch

Rejecting patch 62282 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20707 test cases.
animations/play-state.html -> failed

Exiting early after 1 failures. 123 tests run.
24.66s total testing time

122 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://queues.webkit.org/results/3562345

[Antonio Gomes]

Comment on attachment 62282 [details]
Patch

lets try again: animations/play-state.html seems flaky, see bug 42821

[Leandro Pereira]

(In reply to comment #10)
> (From update of attachment 62282 [details])
> lets try again: animations/play-state.html seems flaky, see bug 42821

I'm clearing the flags, as this patch has already landed and this test has nothing to do with this build fix :)