Build break on r63881. Linking CXX executable ../Programs/EWebLauncher libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal(WebCore::String const&)' libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess(WebCore::String const&)' libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure(WebCore::String const&)' libewebkit.so: undefined reference to `WebCore::SchemeRegistry::shouldTreatURLAsLocal(WebCore::String const&)' collect2: ld returned 1 exit status
Created attachment 62281 [details] Patch
Created attachment 62282 [details] Patch Sorry. wrong file was uploaded.
Comment on attachment 62282 [details] Patch LGTM. Since it is a bug fix, I'm commit-queuing this without a formal review.
(In reply to comment #3) > (From update of attachment 62282 [details]) > LGTM. Since it is a bug fix, I'm commit-queuing this without a formal review. And by "bug fix", I meant *build* fix.
Comment on attachment 62282 [details] Patch Not sure if the commit-queue understands cq+ for "unreviewed build fix" patches. Lets try r+'ing it.
Comment on attachment 62282 [details] Patch Lets try without r+
Comment on attachment 62282 [details] Patch Clearing flags on attachment: 62282 Committed r63894: <http://trac.webkit.org/changeset/63894>
All reviewed patches have been landed. Closing bug.
Comment on attachment 62282 [details] Patch Rejecting patch 62282 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20707 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 24.66s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3562345
Comment on attachment 62282 [details] Patch lets try again: animations/play-state.html seems flaky, see bug 42821
(In reply to comment #10) > (From update of attachment 62282 [details]) > lets try again: animations/play-state.html seems flaky, see bug 42821 I'm clearing the flags, as this patch has already landed and this test has nothing to do with this build fix :)