Bug 42803 – Convert DRT list tests from pixel-tests/render tree dumps to text

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

With the passing of Bug #37929 and Bug #37930, we can convert a subset of the DRT lists tests from pixel-tests/render tree dumps to text.

[Daniel Bates]

Created attachment 62257 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)

[Daniel Bates]

Created attachment 62258 [details]
[Patch] Part 2 of 2 (Remove Mac and Windows render-tree/pixel-tests results)

Remove the render-tree/pixel-test results for some of the Mac and Windows DRT list tests since we are converting these tests to text.

[WebKit Review Bot]

Attachment 62258 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Since the patch is fairly large, I thought to break it up into two parts to make it easier to review the changes. Let me know 

[Patch] Part 1 of 2 (Updated tests and expected results): Includes the modifications of the test files so that they dump text. Also includes the text-based expected results and change log entry.

[Patch] Part 2 of 2 (Remove Mac and Windows render-tree/pixel-tests results): The patch removes all of the render-tree/pixel-test results of the converted tests.

I converted the following tests to text:

fast/lists/alpha-boundary-values.html
fast/lists/alpha-list-wrap.html
fast/lists/decimal-leading-zero.html
fast/lists/li-values.html
fast/lists/list-style-type-dynamic-change.html
fast/lists/w3-css3-list-styles-alphabetic.html
fast/lists/w3-css3-list-styles-numeric.html
fast/lists/w3-list-styles.html

Let me know if I should break up either part of this patch further.

[Daniel Bates]

Created attachment 62259 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)

Update change log so that the line for "fast/lists/list-style-type-dynamic-change.html" has the remark "Modified to dump as text."

[Daniel Bates]

Created attachment 62261 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)

Fix typos in fast/lists/w3-css3-list-styles-numeric.html for binary list-style-type results.

[Darin Adler]

Comment on attachment 62261 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)

These new versions of the tests all seem OK and some even seem great.

[Daniel Bates]

Committed r64186: <http://trac.webkit.org/changeset/64186>

[WebKit Review Bot]

http://trac.webkit.org/changeset/64186 might have broken Qt Linux Release

[Daniel Bates]

(In reply to comment #9)
> http://trac.webkit.org/changeset/64186 might have broken Qt Linux Release

Inadvertently did not remove the platform-specific expected results in the Qt and GTK ports. These platform-specific render-tree/pixel test results are no longer needed since the test dump as text.

Removed these files in changeset 64188 <http://trac.webkit.org/changeset/64188>.