Bug 42794 - Let's pass the doctype01.dat tests again, please
Summary: Let's pass the doctype01.dat tests again, please
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
Depends on:
Blocks: 41123
  Show dependency treegraph
Reported: 2010-07-21 16:15 PDT by Adam Barth
Modified: 2010-07-21 18:08 PDT (History)
2 users (show)

See Also:

Patch (13.97 KB, patch)
2010-07-21 16:18 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-21 16:15:52 PDT
Let's pass the doctype01.dat tests again, please
Comment 1 Adam Barth 2010-07-21 16:18:31 PDT
Created attachment 62244 [details]
Comment 2 Eric Seidel (no email) 2010-07-21 16:20:35 PDT
Comment on attachment 62244 [details]

Isn't our dom2string.js directly from upstream?  Does the upstream version have this bug?
Comment 3 Adam Barth 2010-07-21 16:54:51 PDT
Yeah, I've been discussing that with gsnedders in #whatwg.  There isn't a more awesome version anywhere.  I think he might grab this diff and apply it upstream.  He also mentioned wanting to rev the whole runner.html.
Comment 4 Sam Sneddon [:gsnedders] 2010-07-21 17:00:10 PDT
Eric: which upstream version? As far as I know the upstream versions of it are just what myself and Simon have up on html5.org, which are in varying states of out-of-dateness. Both have this bug.

I was intending on updating the copy I have to fix a number of issues in the runner soon, I'll try and include the fix for this in it.

However, the patch is wrong; it should be: if (current.publicId !== null || current.systemId !== null)
Comment 5 Adam Barth 2010-07-21 17:08:45 PDT
Will fix before landing.
Comment 6 Adam Barth 2010-07-21 18:06:54 PDT
Hum...  That doesn't actually work.  I think that's because of we're bad at handling NULL public and system identifiers.  I'll change it in a future patch.
Comment 7 Adam Barth 2010-07-21 18:08:43 PDT
Comment on attachment 62244 [details]

Clearing flags on attachment: 62244

Committed r63871: <http://trac.webkit.org/changeset/63871>
Comment 8 Adam Barth 2010-07-21 18:08:49 PDT
All reviewed patches have been landed.  Closing bug.