Bug 42791 - Update a list of tags to match changes in the HTML5 spec
Summary: Update a list of tags to match changes in the HTML5 spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-21 14:53 PDT by Adam Barth
Modified: 2010-07-21 18:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.51 KB, patch)
2010-07-21 14:54 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-21 14:53:53 PDT
Update a list of tags to match changes in the HTML5 spec
Comment 1 Adam Barth 2010-07-21 14:54:54 PDT
Created attachment 62237 [details]
Patch
Comment 2 Darin Adler 2010-07-21 14:56:21 PDT
Comment on attachment 62237 [details]
Patch

Since we're going to need these in HTMLTags.in later anyway, why not add them now?

> +        || token.name() == "figcaption"
> +        || token.name() == "summary"
Comment 3 Eric Seidel (no email) 2010-07-21 15:44:01 PDT
Comment on attachment 62237 [details]
Patch

We definitely have a bunch of tags to add to htmlnames.in.  Soon we'll do them all in one batch when we can sing the praises of the 5% perf win it gets us. :)
Comment 4 Adam Barth 2010-07-21 15:47:48 PDT
Comment on attachment 62237 [details]
Patch

I'll add them all at once.
Comment 5 WebKit Commit Bot 2010-07-21 16:23:34 PDT
Comment on attachment 62237 [details]
Patch

Rejecting patch 62237 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
Last 500 characters of output:
file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/html5lib/runner-expected-html5.txt
Hunk #1 FAILED at 432.
Hunk #2 FAILED at 452.
2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #1 succeeded at 810 (offset 1 line).
Hunk #2 succeeded at 820 with fuzz 2 (offset 1 line).

Full output: http://queues.webkit.org/results/3559331
Comment 6 Adam Barth 2010-07-21 18:03:25 PDT
Comment on attachment 62237 [details]
Patch

Clearing flags on attachment: 62237

Committed r63869: <http://trac.webkit.org/changeset/63869>
Comment 7 Adam Barth 2010-07-21 18:03:30 PDT
All reviewed patches have been landed.  Closing bug.