Bug 42668 - Fix fast/dom/title-content-write-set.html for HTML5 tree builder
Summary: Fix fast/dom/title-content-write-set.html for HTML5 tree builder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-20 14:25 PDT by Adam Barth
Modified: 2010-07-20 16:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.07 KB, patch)
2010-07-20 14:36 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (4.68 KB, patch)
2010-07-20 15:11 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (4.37 KB, patch)
2010-07-20 15:18 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-20 14:25:42 PDT
Fix fast/dom/title-content-write-set.html for HTML5 tree builder
Comment 1 Adam Barth 2010-07-20 14:36:12 PDT
Created attachment 62113 [details]
Patch
Comment 2 Darin Adler 2010-07-20 14:50:49 PDT
Comment on attachment 62113 [details]
Patch

> -PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg)
> +PassRefPtr<StringImpl> CharacterData::appendDataCommon(const String& arg)

> +void CharacterData::parserAppendData(const String& arg)

> +    PassRefPtr<StringImpl> appendDataCommon(const String& arg);

Please omit the name "arg" here. It doesn't add anything.
Comment 3 Darin Adler 2010-07-20 14:51:18 PDT
Comment on attachment 62113 [details]
Patch

> -PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg)
> +PassRefPtr<StringImpl> CharacterData::appendDataCommon(const String& arg)

> +void CharacterData::parserAppendData(const String& arg)

I meant to say. Are you willing to use a word, such as "data" here, instead of an abbreviation, "arg"?
Comment 4 Eric Seidel (no email) 2010-07-20 14:51:36 PDT
Comment on attachment 62113 [details]
Patch

It seems the main cause of this bug is that dispatchModifiedEvent has a bad name.  It really should say something about calling childrenChanged, or be split into two functions or something.
Comment 5 Adam Barth 2010-07-20 15:00:13 PDT
> I meant to say. Are you willing to use a word, such as "data" here, instead of an abbreviation, "arg"?

Yeah, data is a better name.  I brought the name forward from the code originally with out thinking about it.
Comment 6 Adam Barth 2010-07-20 15:11:20 PDT
Created attachment 62121 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2010-07-20 15:12:34 PDT
Comment on attachment 62113 [details]
Patch

Clearing flags on attachment: 62113

Committed r63779: <http://trac.webkit.org/changeset/63779>
Comment 8 WebKit Commit Bot 2010-07-20 15:12:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Adam Barth 2010-07-20 15:13:42 PDT
Darn, the commit bot picked up the patch before I removed cq+.  I'll land a followup patch.
Comment 10 Adam Barth 2010-07-20 15:18:01 PDT
Created attachment 62122 [details]
Patch for landing
Comment 11 Adam Barth 2010-07-20 15:18:42 PDT
Reopening so the commit bot can land the updated patch.
Comment 12 WebKit Commit Bot 2010-07-20 16:03:08 PDT
Comment on attachment 62122 [details]
Patch for landing

Clearing flags on attachment: 62122

Committed r63782: <http://trac.webkit.org/changeset/63782>
Comment 13 WebKit Commit Bot 2010-07-20 16:03:13 PDT
All reviewed patches have been landed.  Closing bug.