Bug 42638 - [Qt] Fix WebKit2 build
Summary: [Qt] Fix WebKit2 build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 42830
  Show dependency tree / graph
 
Reported: 2010-07-20 06:37 PDT by Balazs Kelemen
Modified: 2010-07-22 10:04 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (5.20 KB, patch)
2010-07-20 06:44 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
proposed patch - fixed fix (5.25 KB, patch)
2010-07-20 08:06 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
proposed patch (2.60 KB, patch)
2010-07-22 09:44 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-07-20 06:37:57 PDT 
The build of the qt port of webkit2 is broken and needs update.
Comment 1 Balazs Kelemen 2010-07-20 06:44:07 PDT 
Created attachment 62068 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-07-20 06:47:26 PDT 
Attachment 62068 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/qt/WebContextQt.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Balazs Kelemen 2010-07-20 08:06:24 PDT 
Created attachment 62077 [details]
proposed patch - fixed fix
Comment 4 WebKit Review Bot 2010-07-20 08:08:19 PDT 
Attachment 62077 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/qt/WebContextQt.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Balazs Kelemen 2010-07-22 09:24:58 PDT 
Comment on attachment 62077 [details]
proposed patch - fixed fix

The patch has been outdated, I will update soon.
Comment 6 Balazs Kelemen 2010-07-22 09:44:34 PDT 
Created attachment 62310 [details]
proposed patch
Comment 7 Andras Becsi 2010-07-22 10:01:54 PDT 
Comment on attachment 62310 [details]
proposed patch

Buildfix committed in revision 63898.
Comment 8 Andras Becsi 2010-07-22 10:04:26 PDT 
Issue fixed, closing bug.