Bug 42830 - [Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
Summary: [Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on: 42638
Blocks:
  Show dependency tree / graph
 
Reported: 2010-07-22 08:43 PDT by Andras Becsi
Modified: 2010-07-22 11:01 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch (4.02 KB, patch)
2010-07-22 08:48 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
proposed patch v2 (3.99 KB, patch)
2010-07-22 10:10 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-07-22 08:43:51 PDT 
Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
Comment 1 Andras Becsi 2010-07-22 08:48:35 PDT 
Created attachment 62303 [details]
proposed patch
Comment 2 Andras Becsi 2010-07-22 10:10:36 PDT 
Created attachment 62311 [details]
proposed patch v2

WK2 does not need config.h. Fixed the patch.
Comment 3 WebKit Review Bot 2010-07-22 10:15:14 PDT 
Attachment 62311 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/qt/WebContextQt.cpp:27:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andras Becsi 2010-07-22 11:01:37 PDT 
Comment on attachment 62311 [details]
proposed patch v2

Clearing flags on attachment: 62311

Committed r63902: <http://trac.webkit.org/changeset/63902>
Comment 5 Andras Becsi 2010-07-22 11:01:46 PDT 
All reviewed patches have been landed.  Closing bug.