WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
42830
[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42830
Summary
[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of Web...
Andras Becsi
Reported
2010-07-22 08:43:51 PDT
Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
Attachments
proposed patch
(4.02 KB, patch)
2010-07-22 08:48 PDT
,
Andras Becsi
no flags
Details
Formatted Diff
Diff
proposed patch v2
(3.99 KB, patch)
2010-07-22 10:10 PDT
,
Andras Becsi
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andras Becsi
Comment 1
2010-07-22 08:48:35 PDT
Created
attachment 62303
[details]
proposed patch
Andras Becsi
Comment 2
2010-07-22 10:10:36 PDT
Created
attachment 62311
[details]
proposed patch v2 WK2 does not need config.h. Fixed the patch.
WebKit Review Bot
Comment 3
2010-07-22 10:15:14 PDT
Attachment 62311
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/qt/WebContextQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andras Becsi
Comment 4
2010-07-22 11:01:37 PDT
Comment on
attachment 62311
[details]
proposed patch v2 Clearing flags on attachment: 62311 Committed
r63902
: <
http://trac.webkit.org/changeset/63902
>
Andras Becsi
Comment 5
2010-07-22 11:01:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug