Bug 42590 - Import a number of fast/invalid tests into html5lib for easy of fixing
Summary: Import a number of fast/invalid tests into html5lib for easy of fixing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-19 13:39 PDT by Adam Barth
Modified: 2010-07-20 00:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (16.06 KB, patch)
2010-07-19 13:40 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-19 13:39:18 PDT 
Import a number of fast/invalid tests into html5lib for easy of fixing
Comment 1 Adam Barth 2010-07-19 13:40:32 PDT 
Created attachment 61987 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-19 13:56:36 PDT 
Comment on attachment 61987 [details]
Patch

LGTM.  I'm glad we're not removing the originals since they've shown bugs.

We really need a way to make any normal test dump a dom tree instead of a render tree.
Comment 3 Darin Adler 2010-07-19 14:00:59 PDT 
(In reply to comment #2)
> We really need a way to make any normal test dump a dom tree instead of a render tree.

We can probably do that with a JavaScript function and dumpAsText.
Comment 4 WebKit Commit Bot 2010-07-20 00:20:35 PDT 
Comment on attachment 61987 [details]
Patch

Clearing flags on attachment: 61987

Committed r63728: <http://trac.webkit.org/changeset/63728>
Comment 5 WebKit Commit Bot 2010-07-20 00:20:40 PDT 
All reviewed patches have been landed.  Closing bug.