Bug 42431 - Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
Summary: Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-15 17:40 PDT by Adam Barth
Modified: 2010-07-15 23:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (32.03 KB, patch)
2010-07-15 17:47 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (31.03 KB, patch)
2010-07-15 20:45 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-15 17:40:59 PDT 
Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
Comment 1 Adam Barth 2010-07-15 17:47:00 PDT 
Created attachment 61754 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-15 18:34:55 PDT 
Comment on attachment 61754 [details]
Patch

LayoutTests/platform/mac/fast/css/style-parsed-outside-head-expected.txt:5
 +      RenderBlock (anonymous) at (0,0) size 785x18
You some how ended up with text content before the <body>.  That seems wrong.  I think your change is not quite right. I think you need to check that it's only whitespace before inserting it before the body.
Comment 3 Adam Barth 2010-07-15 20:45:56 PDT 
Created attachment 61762 [details]
Patch
Comment 4 WebKit Commit Bot 2010-07-15 21:55:41 PDT 
Comment on attachment 61762 [details]
Patch

Rejecting patch 61762 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
hive
	M	LayoutTests/webarchive/test-object-data-expected.webarchive
	M	LayoutTests/webarchive/test-script-src-expected.webarchive
	M	LayoutTests/webarchive/test-table-background-expected.webarchive
	M	LayoutTests/webarchive/test-td-background-expected.webarchive
	M	WebCore/ChangeLog
	M	WebCore/html/LegacyHTMLTreeBuilder.cpp
Merge conflict during commit: MERGE request failed on '/repository/webkit/trunk': Conflict at '/trunk/WebCore/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 570


Full output: http://webkit-commit-queue.appspot.com/results/3348716
Comment 5 Eric Seidel (no email) 2010-07-15 21:57:42 PDT 
Comment on attachment 61762 [details]
Patch

I'm surprised that's not a recoverable error.
Comment 6 Adam Barth 2010-07-15 22:16:27 PDT 
Comment on attachment 61762 [details]
Patch

Clearing flags on attachment: 61762

Committed r63517: <http://trac.webkit.org/changeset/63517>
Comment 7 Adam Barth 2010-07-15 22:16:33 PDT 
All reviewed patches have been landed.  Closing bug.