Add WebCore/bindings/generic/RunTimeEnabledFeatures.cpp to build files
Uploading patch to see what the EWS bots say.
Created attachment 61671 [details] Patch
Uploading new patch that updates the XCode project, Android makefiles, and adds an #include in Page.cpp to make the EWS bots actually fail if it can't be found.
Created attachment 61688 [details] Patch
Attachment 61688 [details] did not build on win: Build output: http://webkit-commit-queue.appspot.com/results/3349699
Created attachment 61784 [details] Patch
Rebasing, hoping the win bot will be able to apply the patch this time.
Created attachment 61802 [details] Patch
Created attachment 61883 [details] Patch
Created attachment 61931 [details] Patch
Comment on attachment 61931 [details] Patch It would be good to describe the motivation for this patch in the bug. > bindings/generic a while a go (in r54593), but needs to needs -> need > be added to the build in order to be used. Add a tests line, saying that there are no new tests because this patch introduces no change in functionality > WebCore/WebCore.vcproj/WebCore.vcproj Did you make the change by hand, or with VisualStudio? > WebCore/page/Page.cpp Did you intend this change to be submitted, or is just for testing on the bots? I'll help you land the patch manually if the Win EWS bot continues to give problems.
(In reply to comment #11) > (From update of attachment 61931 [details]) > It would be good to describe the motivation for this patch in the bug. The motivation is to make the functions in RuntimeEnabledFeatures.h available in WebCore so that the device orientation code can add an use an enable-switch here. I'd love to add this to the description of the bug, but I don't think it can be edited? > > > bindings/generic a while a go (in r54593), but needs to > needs -> need Done. > > > be added to the build in order to be used. > Add a tests line, saying that there are no new tests because this patch introduces no change in functionality Done. > > > WebCore/WebCore.vcproj/WebCore.vcproj > Did you make the change by hand, or with VisualStudio? By hand, as I don't have access to the supported Visual Studio version. This is why I'm anxious to have a Win bot test it. > > > WebCore/page/Page.cpp > Did you intend this change to be submitted, or is just for testing on the bots? It's just to make sure the bots fail if the .h file fails to be included. I was planning to take it out when all the EWS bots were green, but if we can't get the Win EWS bot to run this patch, perhaps we should leave it in so it gets tested by the real bots? > > I'll help you land the patch manually if the Win EWS bot continues to give problems. Thanks. Much appreciated.
Created attachment 61937 [details] Patch
Created attachment 61960 [details] Patch Rebased and removed dos line endings from the part that touches the .vcproj file.
Created attachment 61966 [details] Patch Same patch again. Will hopefully apply on the Windows bot even though it fails on all the rest.
> Same patch again. Will hopefully apply on the Windows bot even though it fails on all the rest. It did indeed apply and build OK on Windows. What's strange is that recent patches which touch the VS project file have applied successfully on all EWS bots. In Bug 41518, Bug 41607 and Bug 42104, although the patches didn't build on the Windows EWS bot, they did get as far as failing to build, which presumably means that the patch was successfully applied. CC'ing Eric to see if he has any ideas. I think we've wasted enough time on this, so tomorrow let's land the version with the DOS line endings (and without the change to Page.cpp) and watch the build bots.
Since the patch has now built successfully on all bots, I'm uploading again with untampered line endings and without the change to Page.cpp. This should land fine with the commit queue.
Created attachment 62041 [details] Patch
Comment on attachment 62041 [details] Patch r=me Please watch the build bots!
Comment on attachment 62041 [details] Patch Clearing flags on attachment: 62041 Committed r63735: <http://trac.webkit.org/changeset/63735>
All reviewed patches have been landed. Closing bug.