Bug 42366 - [Qt] Improve test coverage for the QScriptValue
Summary: [Qt] Improve test coverage for the QScriptValue
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Jędrzej Nowacki
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31863
  Show dependency treegraph
Reported: 2010-07-15 06:41 PDT by Jędrzej Nowacki
Modified: 2010-07-27 15:16 PDT (History)
5 users (show)

See Also:

Fix v1 (108.73 KB, patch)
2010-07-27 08:07 PDT, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-07-15 06:41:36 PDT
QtScript have a great test coverage, but it could be even better.

Now the QScriptValue autotest use a set of values to check API, the set is initialized before each test case. Because of a lazy nature of a QScriptValue object, it is not perfect. The value after first contact with an engine get bound to it, so all other tests check modified version of the value. This was the main cause why bug 42363 was found in a benchmarks and not in an autotests.

I propose to recreate all values before each test.
Comment 1 Jędrzej Nowacki 2010-07-27 08:07:04 PDT
Created attachment 62691 [details]
Fix v1
Comment 2 Kenneth Rohde Christiansen 2010-07-27 14:16:33 PDT
Comment on attachment 62691 [details]
Fix v1

Good work!
Comment 3 WebKit Commit Bot 2010-07-27 15:16:27 PDT
Comment on attachment 62691 [details]
Fix v1

Clearing flags on attachment: 62691

Committed r64165: <http://trac.webkit.org/changeset/64165>
Comment 4 WebKit Commit Bot 2010-07-27 15:16:31 PDT
All reviewed patches have been landed.  Closing bug.